From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-unionfs@vger.kernel.org
Subject: [PATCH v2 0/2] overlayfs forward compat index changes
Date: Tue, 18 Jul 2017 21:07:41 +0300 [thread overview]
Message-ID: <1500401263-25562-1-git-send-email-amir73il@gmail.com> (raw)
Miklos,
I did not get any NACK nor ACK from you on the patch:
[08/10] ovl: do not cleanup directory and whiteout index entries
from the v4.13 assorted fixes series.
So I've NACKed it myself, because we should not be allowing
rw mount with index entries from the future.
So patch 1 is resend of that patch which returns EROFS from
ovl_indexdir_cleanup() if entries from the future are found.
I'll leave it to you to decide if this error translates to
mount failure or fallback to read-only mount.
Patch 2 takes care of another forward compact issue related
index entries from the future in ovl_lookup_index(), but it
is really a sanity check that we should have had there (we
forgot to check that found index is of same file type as lower).
FYI, I have a WIP for whiteout index implementation at [1]
with these patched:
ovl: verify directory and whiteout index entries
ovl: whiteout index on last unlink
Thanks,
Amir.
[1] https://github.com/amir73il/linux/commits/ovl-index-wip
Amir Goldstein (2):
ovl: do not cleanup directory and whiteout index entries
ovl: check for bad and whiteout index on lookup
fs/overlayfs/namei.c | 41 ++++++++++++++++++++++++++++++++---------
fs/overlayfs/readdir.c | 5 ++++-
2 files changed, 36 insertions(+), 10 deletions(-)
--
2.7.4
next reply other threads:[~2017-07-18 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 18:07 Amir Goldstein [this message]
2017-07-18 18:07 ` [PATCH v2 1/2] ovl: do not cleanup directory and whiteout index entries Amir Goldstein
2017-07-18 18:07 ` [PATCH v2 2/2] ovl: check for bad and whiteout index on lookup Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500401263-25562-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox