From: "zhangyi (F)" <yi.zhang@huawei.com>
To: fstests@vger.kernel.org
Cc: eguan@redhat.com, linux-unionfs@vger.kernel.org,
miklos@szeredi.hu, amir73il@gmail.com, yi.zhang@huawei.com,
miaoxie@huawei.com
Subject: [PATCH xfstests 1/2] overlay: test relatime for directories
Date: Thu, 14 Sep 2017 20:04:02 +0800 [thread overview]
Message-ID: <1505390643-6981-1-git-send-email-yi.zhang@huawei.com> (raw)
Add test access time update issue for directories in upper layer.
Upstream commit cd91304e7190 ("ovl: fix relatime for directories")
fixed this issue.
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
---
tests/overlay/039 | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++
tests/overlay/039.out | 2 ++
tests/overlay/group | 1 +
3 files changed, 92 insertions(+)
create mode 100755 tests/overlay/039
create mode 100644 tests/overlay/039.out
diff --git a/tests/overlay/039 b/tests/overlay/039
new file mode 100755
index 0000000..cd81ce5
--- /dev/null
+++ b/tests/overlay/039
@@ -0,0 +1,89 @@
+#! /bin/bash
+# FS QA Test 039
+#
+# Test access time update issue for directories in upper layer.
+#
+# Upstream Commit cd91304e7190 ("ovl: fix relatime for directories")
+# fixed this issue.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2017 Huawei. All Rights Reserved.
+# Author: zhangyi (F) <yi.zhang@huawei.com>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+_supported_fs overlay
+_supported_os Linux
+_require_scratch
+_require_relatime
+
+# remove all files from previous runs
+_scratch_mkfs
+
+lowerdir=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER
+upperdir=$OVL_BASE_SCRATCH_MNT/$OVL_UPPER
+mkdir -p $upperdir/test
+
+_scratch_mount "-o relatime"
+
+# access test dir, it's access time will be updated normally
+ls $SCRATCH_MNT/test
+
+pre_access_time=`stat -c "%X" $SCRATCH_MNT/test`
+
+# In relatime mode, access time is only updated if the previous
+# access time was earlier than the current modify or change time,
+# so trigger modify and change time update.
+touch $SCRATCH_MNT/test/foo
+sleep 1
+
+# access test dir again
+ls $SCRATCH_MNT/test > /dev/null 2>&1
+
+cur_access_time=`stat -c "%X" $SCRATCH_MNT/test`
+
+# compare the results, current access time should later than the previous one
+if [ $cur_access_time -le $pre_access_time ] ; then
+ echo "Access time is not updated correctly."
+fi
+
+# success, all done
+echo "Silence is golden"
+status=0
+exit
diff --git a/tests/overlay/039.out b/tests/overlay/039.out
new file mode 100644
index 0000000..d4e7ef6
--- /dev/null
+++ b/tests/overlay/039.out
@@ -0,0 +1,2 @@
+QA output created by 039
+Silence is golden
diff --git a/tests/overlay/group b/tests/overlay/group
index ac66bc7..39177c4 100644
--- a/tests/overlay/group
+++ b/tests/overlay/group
@@ -41,3 +41,4 @@
036 auto quick mount
037 auto quick mount
038 auto quick copyup
+039 auto quick
--
2.5.0
next reply other threads:[~2017-09-14 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 12:04 zhangyi (F) [this message]
2017-09-14 12:04 ` [PATCH xfstests 2/2] overlay: test chattr lower file in overlay zhangyi (F)
2017-09-14 13:07 ` Amir Goldstein
2017-09-14 13:31 ` Eryu Guan
2017-09-15 1:06 ` zhangyi (F)
2017-09-14 13:07 ` [PATCH xfstests 1/2] overlay: test relatime for directories Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505390643-6981-1-git-send-email-yi.zhang@huawei.com \
--to=yi.zhang@huawei.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).