linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 0/4] fstests: fixes for config option OVERLAY_MOUNT_OPTIONS
Date: Wed, 27 Sep 2017 10:04:08 +0300	[thread overview]
Message-ID: <1506495852-7295-1-git-send-email-amir73il@gmail.com> (raw)

Eryu,

Since v4.13, overlayfs supports mount option index=on/off per mount
and kernel config option CONFIG_OVERLAY_FS_INDEX that sets the default
system wide value when mount option is not specified.

The behavior of overlayfs may differ for index=on/off, specifically
for hardlinks. It is therefore important to be able to test overlayfs
with both index=on/off.

To that end exists the OVERLAY_MOUNT_OPTIONS config option, only
when I tried to use it I found it was broken in more than one way.
This series fixed the use of OVERLAY_MOUNT_OPTIONS and refactors
some customized overlay mount helpers along the way.

NOTE for users of kvm-xfstests, this test-appliance change is also
required for invoking kvm-xfstests -m index=on/off
https://github.com/tytso/xfstests-bld/pull/4

Amir Goldstein (4):
  overlay: remove stale implementation of _scratch_mount_options
  overlay: use default overlay mount options _overlay_mount_dirs()
  overlay: create helper _overlay_scratch_mount_dirs()
  overlay: fix _overlay_config_override of MOUNT_OPTIONS

 common/config     |  4 ++++
 common/rc         | 36 ++++++++++++++++--------------------
 tests/overlay/005 |  2 +-
 tests/overlay/010 |  3 +--
 tests/overlay/014 |  8 +++-----
 tests/overlay/031 | 11 +++++------
 tests/overlay/035 |  3 +--
 tests/overlay/037 | 14 ++++++--------
 tests/overlay/038 |  3 +--
 9 files changed, 38 insertions(+), 46 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-09-27  7:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  7:04 Amir Goldstein [this message]
2017-09-27  7:04 ` [PATCH 1/4] overlay: remove stale implementation of _scratch_mount_options Amir Goldstein
2017-09-27  7:04 ` [PATCH 2/4] overlay: use default overlay mount options _overlay_mount_dirs() Amir Goldstein
2017-09-27  7:50   ` Amir Goldstein
2017-09-27  8:05     ` Eryu Guan
2017-10-12  6:08       ` Eryu Guan
2017-10-11 11:33   ` Eryu Guan
2017-09-27  7:04 ` [PATCH 3/4] overlay: create helper _overlay_scratch_mount_dirs() Amir Goldstein
2017-09-27  7:04 ` [PATCH 4/4] overlay: fix _overlay_config_override of MOUNT_OPTIONS Amir Goldstein
2017-10-11 11:50   ` Eryu Guan
2017-10-11 12:35     ` Amir Goldstein
2017-09-27 10:47 ` [PATCH 5/5] overlay: move _overlay helpers to common/overlay Amir Goldstein
2017-09-28 11:55 ` [PATCH 6/6] overlay: deduplicate code in overlay mount helpers Amir Goldstein
2017-09-29  1:44   ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506495852-7295-1-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).