From: Vivek Goyal <vgoyal@redhat.com>
To: linux-unionfs@vger.kernel.org
Cc: amir73il@gmail.com, miklos@szeredi.hu, vgoyal@redhat.com
Subject: [PATCH 7/8] ovl: Return lower dentry if only metadata copy up took place
Date: Fri, 6 Oct 2017 13:47:16 -0400 [thread overview]
Message-ID: <1507312037-30909-8-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1507312037-30909-1-git-send-email-vgoyal@redhat.com>
Upper dentry inode does not have data. So return lower dentry if upper
is only a metadata copy.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
fs/overlayfs/super.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 338fb0c3d345..0877b4baf14b 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -101,10 +101,14 @@ static struct dentry *ovl_d_real(struct dentry *dentry,
err = ovl_check_append_only(d_inode(real), open_flags);
if (err)
return ERR_PTR(err);
+
+ if (ovl_test_flag(OVL_METACOPY, d_inode(dentry)))
+ goto lower;
}
return real;
}
+lower:
real = ovl_dentry_lower(dentry);
if (!real)
goto bug;
--
2.13.5
next prev parent reply other threads:[~2017-10-06 17:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 17:47 [RFC PATCH 0/8][V2] overlayfs: Delayed copy up of data Vivek Goyal
2017-10-06 17:47 ` [PATCH 1/8] ovl: ovl_check_setxattr() get rid of redundant -EOPNOTSUPP check Vivek Goyal
2017-10-06 17:47 ` [PATCH 2/8] ovl: During copy up, first copy up metadata and then data Vivek Goyal
2017-10-06 17:47 ` [PATCH 3/8] ovl: Provide a mount option metacopy=on/off for metadata copyup Vivek Goyal
2017-10-06 19:01 ` Amir Goldstein
2017-10-09 14:53 ` Vivek Goyal
2017-10-06 17:47 ` [PATCH 4/8] ovl: Copy up only metadata during copy up where it makes sense Vivek Goyal
2017-10-06 17:47 ` [PATCH 5/8] ovl: Set xattr OVL_XATTR_METACOPY on upper file Vivek Goyal
2017-10-06 17:47 ` [PATCH 6/8] ovl: Set OVL_METACOPY flag during ovl_lookup() Vivek Goyal
2017-10-06 17:47 ` Vivek Goyal [this message]
2017-10-06 17:47 ` [PATCH 8/8] ovl: Fix ovl_getattr() to get number of blocks from lower Vivek Goyal
2017-10-06 18:58 ` Amir Goldstein
2017-10-06 19:01 ` Vivek Goyal
2017-10-06 19:09 ` Amir Goldstein
2017-10-09 14:45 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507312037-30909-8-git-send-email-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).