linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-unionfs@vger.kernel.org
Subject: [PATCH 2/4] ovl: declare index feature backward compatible
Date: Tue, 24 Oct 2017 13:02:59 +0300	[thread overview]
Message-ID: <1508839381-24750-3-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1508839381-24750-1-git-send-email-amir73il@gmail.com>

Kconfig description on OVERLAY_FS_INDEX states that "the inodes index
feature is read-only backward compatible" and that mounting an overlay
with index enabled, disabled and then enabled again "will have
unexpected results."

Commit d1712d8fef03 ("ovl: fix EIO from lookup of non-indexed upper")
makes the results of this enable/disable/enable maneuver just as
expected and the results of a plain enable of index feature on existing
overlay - some hardlinks may have already been broken and new hardlinks
will not be broken on copy up.

Now that there is a dedicated config option to opt-in in for backward
incompatible index feature, remove the backward compatibility clause from
Kconfig description of OVERLAY_FS_INDEX.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 fs/overlayfs/Kconfig | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/overlayfs/Kconfig b/fs/overlayfs/Kconfig
index e5e6dec7d177..02295e10ffbe 100644
--- a/fs/overlayfs/Kconfig
+++ b/fs/overlayfs/Kconfig
@@ -37,13 +37,6 @@ config OVERLAY_FS_INDEX
 	  The inodes index feature prevents breaking of lower hardlinks on copy
 	  up.
 
-	  Note, that the inodes index feature is read-only backward compatible.
-	  That is, mounting an overlay which has an index dir on a kernel that
-	  doesn't support this feature read-only, will not have any negative
-	  outcomes.  However, mounting the same overlay with an old kernel
-	  read-write and then mounting it again with a new kernel, will have
-	  unexpected results.
-
 config OVERLAY_FS_INDEX_INCOMPAT
 	bool "Overlayfs: support incompatible index feature"
 	depends on OVERLAY_FS_INDEX
-- 
2.7.4

  parent reply	other threads:[~2017-10-24 10:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 10:02 [PATCH 0/4] Overlayfs index features Amir Goldstein
2017-10-24 10:02 ` [PATCH 1/4] ovl: introduce incompatible index feature Amir Goldstein
2017-11-10 13:57   ` Vivek Goyal
2017-11-10 14:46     ` Amir Goldstein
2017-11-15 14:34       ` Vivek Goyal
2017-11-15 15:14         ` Amir Goldstein
2017-10-24 10:02 ` Amir Goldstein [this message]
2017-11-10 14:21   ` [PATCH 2/4] ovl: declare index feature backward compatible Vivek Goyal
2017-11-10 14:29     ` Amir Goldstein
2017-10-24 10:03 ` [PATCH 3/4] ovl: cast a shadow of incomapt index into the past Amir Goldstein
2017-11-10 14:53   ` Vivek Goyal
2017-11-10 16:30     ` Amir Goldstein
2017-10-24 10:03 ` [PATCH 4/4] ovl: check incompat/rocompat index features Amir Goldstein
2017-10-24 15:30 ` [PATCH 0/4] Overlayfs " Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508839381-24750-3-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).