From: Vivek Goyal <vgoyal@redhat.com>
To: linux-unionfs@vger.kernel.org
Cc: amir73il@gmail.com, miklos@szeredi.hu, vgoyal@redhat.com
Subject: [PATCH 08/13] ovl: Fix ovl_getattr() to get number of blocks from lower
Date: Wed, 25 Oct 2017 15:09:30 -0400 [thread overview]
Message-ID: <1508958575-14086-9-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1508958575-14086-1-git-send-email-vgoyal@redhat.com>
If an inode has been copied up metadata only, then we need to query the
number of blocks from lower and fill up the stat->st_blocks.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
fs/overlayfs/inode.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 1b4b42c..dcc012c 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -140,6 +140,18 @@ int ovl_getattr(const struct path *path, struct kstat *stat,
if (!is_dir && ovl_test_flag(OVL_INDEX, d_inode(dentry)))
stat->nlink = dentry->d_inode->i_nlink;
+ if (ovl_dentry_upper(dentry) && ovl_dentry_check_upperdata(dentry) &&
+ !ovl_test_flag(OVL_UPPERDATA, d_inode(dentry))) {
+ struct kstat lowerstat;
+
+ if (WARN_ON(!OVL_TYPE_ORIGIN(type)))
+ goto out;
+ ovl_path_lower(dentry, &realpath);
+ err = vfs_getattr(&realpath, &lowerstat, STATX_BLOCKS, flags);
+ if (err)
+ goto out;
+ stat->blocks = lowerstat.blocks;
+ }
out:
revert_creds(old_cred);
--
2.5.5
next prev parent reply other threads:[~2017-10-25 19:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 19:09 [RFC PATCH 00/13][V5] overlayfs: Delayed copy up of data Vivek Goyal
2017-10-25 19:09 ` [PATCH 01/13] ovl: Put upperdentry if ovl_check_origin() fails Vivek Goyal
2017-10-25 20:08 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 02/13] ovl: Create origin xattr on copy up for all files Vivek Goyal
2017-10-26 5:31 ` Amir Goldstein
2017-10-26 12:53 ` Vivek Goyal
2017-10-25 19:09 ` [PATCH 03/13] ovl: ovl_check_setxattr() get rid of redundant -EOPNOTSUPP check Vivek Goyal
2017-10-25 19:09 ` [PATCH 04/13] ovl: Provide a mount option metacopy=on/off for metadata copyup Vivek Goyal
2017-10-26 5:39 ` Amir Goldstein
2017-10-26 13:15 ` Vivek Goyal
2017-10-26 13:57 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 05/13] ovl: During copy up, first copy up metadata and then data Vivek Goyal
2017-10-26 5:42 ` Amir Goldstein
2017-10-26 13:19 ` Vivek Goyal
2017-10-25 19:09 ` [PATCH 06/13] ovl: Copy up only metadata during copy up where it makes sense Vivek Goyal
2017-10-25 19:09 ` [PATCH 07/13] ovl: A new xattr OVL_XATTR_METACOPY for file on upper Vivek Goyal
2017-10-26 6:04 ` Amir Goldstein
2017-10-26 13:53 ` Vivek Goyal
2017-10-26 14:14 ` Amir Goldstein
2017-10-26 14:34 ` Vivek Goyal
2017-10-26 16:11 ` Amir Goldstein
2017-10-27 4:28 ` Amir Goldstein
2017-10-25 19:09 ` Vivek Goyal [this message]
2017-10-26 6:12 ` [PATCH 08/13] ovl: Fix ovl_getattr() to get number of blocks from lower Amir Goldstein
2017-10-25 19:09 ` [PATCH 09/13] ovl: Set OVL_UPPERDATA flag during ovl_lookup() Vivek Goyal
2017-10-26 6:19 ` Amir Goldstein
2017-10-26 18:04 ` Vivek Goyal
2017-10-25 19:09 ` [PATCH 10/13] ovl: Return lower dentry if only metadata copy up took place Vivek Goyal
2017-10-25 19:09 ` [PATCH 11/13] ovl: Introduce read/write barriers around metacopy flag update Vivek Goyal
2017-10-26 6:34 ` Amir Goldstein
2017-10-26 17:54 ` Vivek Goyal
2017-10-27 4:35 ` Amir Goldstein
2017-10-27 13:14 ` Vivek Goyal
2017-10-25 19:09 ` [PATCH 12/13] ovl: Do not export metacopy only upper dentry Vivek Goyal
2017-10-26 6:54 ` Amir Goldstein
2017-10-26 6:54 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 13/13] ovl: Enable metadata only feature Vivek Goyal
2017-10-26 7:07 ` Amir Goldstein
2017-10-26 18:19 ` Vivek Goyal
2017-10-26 7:18 ` [RFC PATCH 00/13][V5] overlayfs: Delayed copy up of data Amir Goldstein
2017-10-27 16:40 ` Vivek Goyal
2017-10-28 14:50 ` Amir Goldstein
2017-10-31 13:39 ` Vivek Goyal
2017-10-31 13:56 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508958575-14086-9-git-send-email-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).