linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	linux-unionfs@vger.kernel.org
Subject: [PATCH v6 0/9] Overlayfs: constant st_ino/d_ino for non-samefs
Date: Wed,  1 Nov 2017 22:22:44 +0200	[thread overview]
Message-ID: <1509567773-25590-1-git-send-email-amir73il@gmail.com> (raw)

Miklos,

My trigger for fixing up the non-samefs patches is that I found out
while testing NFS export that reconnecting a dir dentry doesn't work
for non-samefs case.
I tracked the problem down to the default implementation of get_name()
in expfs.c that looks up a child inode in parent dir by d_ino.

First, I rebased NFS export patches onto Chandan's patches and tested,
but that still didn't fix the problem. I found and fixed more cases
that we need to include in impure dir cache (see 2 last patches) and
now my dir file handle unit tests [2] pass.

Changes since v5:
- Justification for moving ovl_entry.h into overlayfs.h
- Split allocate anonymous devs patch to 3 patches
- Explain why we need to return pseudo st_dev for lower
- Fix d_ino of subdirs in non-samefs setup

Besides the NFS export unit tests, I tested these patches with upstream
xfstest overlay/041 by Chandan and with unionmount test
'./run --ov --verify' that is avialble on my unionmount devel branch [3].

I asked Chandan to post fixes to his xfstests to cover the impure cases
I fixes.

Please verify that I didn't mess up authorship when posting Chandan's
patches as I did with zhangyi's patch yesterday. On my branch [1], all
the commits have correct authorship now.

Thanks,
Amir.

[1] https://github.com/amir73il/linux/commits/ovl-nonsamefs-v6
[2] https://github.com/amir73il/xfstests/commits/ovl-nfs-export
[3] https://github.com/amir73il/unionmount-testsuite/commits/overlayfs-devel

Amir Goldstein (5):
  ovl: move include of ovl_entry.h into overlayfs.h
  ovl: relax same fs constraint for constant st_ino
  ovl: update cache version of impure parent on rename
  ovl: update merge dir cache for non-samefs case
  ovl: update non-merge dir cache for non-samefs case

Chandan Rajendra (4):
  ovl: re-structure overlay lower layers in-memory
  ovl: allocate anonymous devs for lowerdirs
  ovl: return anonymous st_dev for lower inodes
  ovl: fix d_ino of current pure upper in non-samefs case

 fs/overlayfs/copy_up.c   |  1 -
 fs/overlayfs/dir.c       | 12 ++++---
 fs/overlayfs/inode.c     | 51 +++++++++++++++++++++---------
 fs/overlayfs/namei.c     | 53 ++++++++++++++++++-------------
 fs/overlayfs/overlayfs.h |  7 +++--
 fs/overlayfs/ovl_entry.h | 14 +++++++--
 fs/overlayfs/readdir.c   | 50 +++++++++++++++++++++++-------
 fs/overlayfs/super.c     | 81 ++++++++++++++++++++++++++++++------------------
 fs/overlayfs/util.c      | 17 +++++++---
 9 files changed, 191 insertions(+), 95 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-11-01 20:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 20:22 Amir Goldstein [this message]
2017-11-01 20:22 ` [PATCH v6 1/9] ovl: move include of ovl_entry.h into overlayfs.h Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 2/9] ovl: re-structure overlay lower layers in-memory Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 3/9] ovl: allocate anonymous devs for lowerdirs Amir Goldstein
2017-11-02 12:28   ` Vivek Goyal
2017-11-02 13:05     ` Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 4/9] ovl: return anonymous st_dev for lower inodes Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 5/9] ovl: relax same fs constraint for constant st_ino Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 6/9] ovl: fix d_ino of current pure upper in non-samefs case Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 7/9] ovl: update cache version of impure parent on rename Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 8/9] ovl: update merge dir cache for non-samefs case Amir Goldstein
2017-11-01 20:22 ` [PATCH v6 9/9] ovl: update non-merge " Amir Goldstein
2017-11-02 16:33 ` [PATCH v6 0/9] Overlayfs: constant st_ino/d_ino for non-samefs Miklos Szeredi
2017-11-02 18:06   ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509567773-25590-1-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).