linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	Vivek Goyal <vgoyal@redhat.com>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 3/3] overlay/042: remove wrong check for empty index
Date: Tue, 28 Nov 2017 18:42:02 +0200	[thread overview]
Message-ID: <1511887322-29254-4-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1511887322-29254-1-git-send-email-amir73il@gmail.com>

The check for empty index in this test was wrongly copied from test
overlay/034. In test overlay/034 lower file starts as a hardlink, so
nlink accounting is done from the first copy up and index can be cleaned
on last upper hardlink unlink. In this test, lower starts as
non-hardlink, so first copy up does not perform nlink accounting and
therefore, union nlink count does not drop to 0 at the end of the test
and the index is not expected to be cleaned.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/overlay/042 | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/overlay/042 b/tests/overlay/042
index dae5198..8967ff3 100755
--- a/tests/overlay/042
+++ b/tests/overlay/042
@@ -129,10 +129,6 @@ rm $SCRATCH_MNT/2
 rm $SCRATCH_MNT/3
 rm $SCRATCH_MNT/4
 
-# Verify that orphan index is cleaned on mount
-_scratch_cycle_mount index=on
-ls $OVL_BASE_SCRATCH_MNT/$OVL_WORK/index
-
 echo "Silence is golden"
 status=0
 exit
-- 
2.7.4

      parent reply	other threads:[~2017-11-28 16:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 16:41 [PATCH 0/3] Overlayfs orphan index cleanup tests Amir Goldstein
2017-11-28 16:42 ` [PATCH 1/3] overlay: regression test for hardlink breakage after unlink and mount cycle Amir Goldstein
2017-11-28 16:42 ` [PATCH 2/3] overlay: regression test for orphan index cleanup on mount Amir Goldstein
2017-11-28 16:42 ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511887322-29254-4-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).