linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
	fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-unionfs@vger.kernel.org
Subject: [PATCH 1/2] overlay: do not set OVL_BASE_FSTYP value to "overlay"
Date: Mon, 27 Aug 2018 21:29:25 +0300	[thread overview]
Message-ID: <1535394566-18837-2-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1535394566-18837-1-git-send-email-amir73il@gmail.com>

The purpose of OVL_BASE_FSTYP is to store the value of FSTYP that is
found in a host config file section.

When there is no host config file or if user sets FSTYP=overlay in config
file, it makes no sense to store the value "overlay" in OVL_BASE_FSTYP
and it is better to leave it empty or leave its current value in tact.

This allows user to set OVL_BASE_FSTYP in config file or before running
the test to support queries about base fs, such as
_require_metadata_journaling, even when running an overlay test.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 common/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/config b/common/config
index 2f1f272..d85519a 100644
--- a/common/config
+++ b/common/config
@@ -530,7 +530,7 @@ _overlay_config_override()
 	[ -b "$TEST_DEV" ] || return 0
 
 	# Config file may specify base fs type, but we obay -overlay flag
-	export OVL_BASE_FSTYP="$FSTYP"
+	[ "$FSTYP" == overlay ] || export OVL_BASE_FSTYP="$FSTYP"
 	export FSTYP=overlay
 
 	# Store original base fs vars
-- 
2.7.4

  reply	other threads:[~2018-08-27 22:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 18:29 [PATCH 0/2] fstests: fix overlay test failure over ext4 Amir Goldstein
2018-08-27 18:29 ` Amir Goldstein [this message]
2018-08-27 18:29 ` [PATCH 2/2] generic/009: fix test failure with overlay " Amir Goldstein
2018-09-01 17:12   ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1535394566-18837-2-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).