From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-unionfs@vger.kernel.org
Subject: [PATCH 2/2] generic/009: fix test failure with overlay over ext4
Date: Mon, 27 Aug 2018 21:29:26 +0300 [thread overview]
Message-ID: <1535394566-18837-3-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1535394566-18837-1-git-send-email-amir73il@gmail.com>
When running test with overlayfs and ext4 as base fs, we need to
disable extent zeroout on the underlying base fs.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
Eryu,
Suggestions for a cleaner approach are welcome.
Thanks,
Amir.
tests/generic/009 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/generic/009 b/tests/generic/009
index fa6ef46..a4f56d0 100755
--- a/tests/generic/009
+++ b/tests/generic/009
@@ -39,6 +39,9 @@ testfile=$TEST_DIR/009.$$
if [ "$FSTYP" = "ext4" ]; then
_ext4_disable_extent_zeroout
fi
+if [ "$FSTYP" = "overlay" -a "$OVL_BASE_FSTYP" = "ext4" ]; then
+ _ext4_disable_extent_zeroout "$OVL_BASE_TEST_DEV"
+fi
# When PAGE_SIZE > 4096 some filesystems extent layout is different so
# it would not match the output.
--
2.7.4
next prev parent reply other threads:[~2018-08-27 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 18:29 [PATCH 0/2] fstests: fix overlay test failure over ext4 Amir Goldstein
2018-08-27 18:29 ` [PATCH 1/2] overlay: do not set OVL_BASE_FSTYP value to "overlay" Amir Goldstein
2018-08-27 18:29 ` Amir Goldstein [this message]
2018-09-01 17:12 ` [PATCH 2/2] generic/009: fix test failure with overlay over ext4 Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535394566-18837-3-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).