From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ovl: Return -ENOMEM if an allocation fails ovl_lookup()
Date: Sat, 23 Sep 2017 09:11:41 +0530 [thread overview]
Message-ID: <1680634.zEmtb0eVgD@localhost.localdomain> (raw)
In-Reply-To: <20170922204518.cqagl2vlh7jiwt6y@mwanda>
On Saturday, September 23, 2017 2:15:18 AM IST Dan Carpenter wrote:
> The error code is missing here so it means we return ERR_PTR(0) or NULL.
> The other error paths all return an error code so this probably should
> as well.
>
> Fixes: 02b69b284cd7 ("ovl: lookup redirects")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
> index c3addd1114f1..beb8a988df51 100644
> --- a/fs/overlayfs/namei.c
> +++ b/fs/overlayfs/namei.c
> @@ -634,6 +634,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
> }
>
> if (d.redirect) {
> + err = -ENOMEM;
> upperredirect = kstrdup(d.redirect, GFP_KERNEL);
> if (!upperredirect)
> goto out_put_upper;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
The patch looks good.
Reviewed-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
--
chandan
prev parent reply other threads:[~2017-09-23 3:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 20:45 [PATCH] ovl: Return -ENOMEM if an allocation fails ovl_lookup() Dan Carpenter
2017-09-23 3:41 ` Chandan Rajendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1680634.zEmtb0eVgD@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox