Linux Overlay Filesystem development
 help / color / mirror / Atom feed
From: Dominique Martinet <dominique.martinet@cea.fr>
To: Vincent Bernat <bernat@luffy.cx>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Ron Minnich <rminnich@sandia.gov>,
	Miklos Szeredi <miklos@szeredi.hu>,
	linux-unionfs@vger.kernel.org,
	David Howells <dhowells@redhat.com>,
	v9fs-developer@lists.sourceforge.net
Subject: Re: [V9fs-developer] 9p/overlayfs: read error when reading an empty file
Date: Mon, 17 Aug 2015 16:11:37 +0200	[thread overview]
Message-ID: <20150817141137.GA15883@u-michard> (raw)
In-Reply-To: <877fowita7.fsf@zoro.exoscale.ch>

Vincent Bernat wrote on Sat, Aug 15, 2015 at 03:18:56PM +0200:
> For this bug, I was able to bisect to this commit:
> 
> 4bacc9c9234c7c8eec44f5ed4e960d9f96fa0f01 is the first bad commit
> commit 4bacc9c9234c7c8eec44f5ed4e960d9f96fa0f01
> Author: David Howells <dhowells@redhat.com>
> Date:   Thu Jun 18 14:32:31 2015 +0100
> 
>     overlayfs: Make f_path always point to the overlay and f_inode to the underlay
> 
> In fact, any file reading of files present in the lower layer will lead
> to this. No need to try to switch root or anything complex.

Hmm, that is going to be annoying to fix, since we use
file->f_path.dentry to get a new fid to the same file (clone), and
current code pretty much depends on that...

I guess it used to work because file->f_op, file->f_inode and
file->f_path used to all be from the same layer, which isn't the case
anymore.


Does any overlayfs person reading this know if it's still possible to
get the right dentry at this point?
I'm sure the object exists somewhere in memory, but it could be annoying
to find.

Thanks,
-- 
Dominique

  reply	other threads:[~2015-08-17 14:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-15  7:37 9p/overlayfs: read error when reading an empty file Vincent Bernat
2015-08-15 11:17 ` Vincent Bernat
2015-08-15 11:57   ` Vincent Bernat
2015-08-15 13:18 ` Vincent Bernat
2015-08-17 14:11   ` Dominique Martinet [this message]
2015-10-03 17:07     ` [V9fs-developer] " Vincent Bernat
2015-10-03 19:19       ` Dominique Martinet
2015-10-12 17:14         ` Miklos Szeredi
2015-10-12 17:47           ` [V9fs-developer] 9p/overlayfs: what inodes/dentries are safe to use? Dominique Martinet
2015-10-13  3:33             ` Miklos Szeredi
2015-10-13 13:10               ` Eric Van Hensbergen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150817141137.GA15883@u-michard \
    --to=dominique.martinet@cea.fr \
    --cc=bernat@luffy.cx \
    --cc=dhowells@redhat.com \
    --cc=ericvh@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=miklos@szeredi.hu \
    --cc=rminnich@sandia.gov \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox