From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-unionfs@vger.kernel.org
Subject: Re: [GIT PULL] overlayfs fixes for 4.6-rc7
Date: Tue, 10 May 2016 16:27:05 +0100 [thread overview]
Message-ID: <20160510152704.GK2694@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160503200403.GB10623@veci.piliscsaba.szeredi.hu>
On Tue, May 03, 2016 at 10:04:03PM +0200, Miklos Szeredi wrote:
> Hi Al,
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
>
> This fixes two issues with overlayfs.
>
> Thanks,
> Miklos
>
> ---
> Miklos Szeredi (3):
> vfs: rename: check backing inode being equal
> vfs: export lookup_hash() to modules
> ovl: ignore permissions on underlying lookup
NAK on lookup_hash(). If nothing else, you need either
lookup_one_len_unlocked() or its "we already know hash" variant (assuming it's
worth bothering with). That locking the parent is potentially a lot costlier
than recalculating the (default) hash function. Especially in -next, where
lookup_one_len_unlocked() will take the lock shared if it has to take it at
all, but the mainline one also has a good chance to avoid taking the lock.
next prev parent reply other threads:[~2016-05-10 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 20:04 [GIT PULL] overlayfs fixes for 4.6-rc7 Miklos Szeredi
2016-05-10 15:27 ` Al Viro [this message]
2016-05-10 20:24 ` Miklos Szeredi
2016-05-10 23:23 ` Miklos Szeredi
2016-05-11 4:07 ` Al Viro
2016-05-11 8:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510152704.GK2694@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox