From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Tyler Hicks <tyhicks@canonical.com>,
ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Serge Hallyn <serge@hallyn.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-ima-devel@lists.sourceforge.net,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
Casey Schaufler <casey@schaufler-ca.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH v6 05/16] sockfs: getxattr: Fail with -EOPNOTSUPP for invalid attribute names
Date: Thu, 29 Sep 2016 13:24:24 -0700 [thread overview]
Message-ID: <20160929202424.GA9499@infradead.org> (raw)
In-Reply-To: <1475164125-28635-6-git-send-email-agruenba@redhat.com>
On Thu, Sep 29, 2016 at 05:48:34PM +0200, Andreas Gruenbacher wrote:
> The standard return value for unsupported attribute names is
> -EOPNOTSUPP, as opposed to undefined but supported attributes
> (-ENODATA).
>
> Also, fail for attribute names like "system.sockprotonameXXX" and
> simplify the code a bit.
The only sensible thing to do with this xattr abuse is to remove it
entirely..
next prev parent reply other threads:[~2016-09-29 20:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 15:48 [PATCH v6 00/16] Xattr inode operation removal Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 01/16] xattr: Remove unnecessary NULL attribute name check Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 02/16] jffs2: Remove jffs2_{get,set,remove}xattr macros Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 03/16] hfs: Switch to generic xattr handlers Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 04/16] kernfs: " Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 05/16] sockfs: getxattr: Fail with -EOPNOTSUPP for invalid attribute names Andreas Gruenbacher
2016-09-29 20:24 ` Christoph Hellwig [this message]
2016-09-29 20:35 ` Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 06/16] sockfs: Get rid of getxattr iop Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 07/16] ecryptfs: Switch to generic xattr handlers Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 08/16] lustre: " Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 09/16] vfs: Move xattr_resolve_name to the front of fs/xattr.c Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 10/16] vfs: Add IOP_XATTR inode operations flag Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 11/16] vfs: Use IOP_XATTR flag for bad-inode handling Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 12/16] libfs: Use IOP_XATTR flag for empty directory handling Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 13/16] xattr: Add __vfs_{get,set,remove}xattr helpers Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 14/16] vfs: Check for the IOP_XATTR flag in listxattr Andreas Gruenbacher
2016-09-29 15:48 ` [PATCH v6 15/16] xattr: Stop calling {get,set,remove}xattr inode operations Andreas Gruenbacher
2016-10-06 21:27 ` Al Viro
2016-09-29 15:48 ` [PATCH v6 16/16] vfs: Remove " Andreas Gruenbacher
2016-10-06 21:34 ` [PATCH v6 00/16] Xattr inode operation removal Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929202424.GA9499@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=ecryptfs@vger.kernel.org \
--cc=eparis@parisplace.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-unionfs@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=serge@hallyn.com \
--cc=tyhicks@canonical.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).