From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eryu Guan Subject: Re: [PATCH v3] overlay: test unstable inode number Date: Mon, 12 Dec 2016 17:26:34 +0800 Message-ID: <20161212092634.GX29149@eguan.usersys.redhat.com> References: <1481532306-26938-1-git-send-email-amir73il@gmail.com> <20161212090851.GW29149@eguan.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: fstests-owner@vger.kernel.org To: Amir Goldstein Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, fstests List-Id: linux-unionfs@vger.kernel.org On Mon, Dec 12, 2016 at 11:21:48AM +0200, Amir Goldstein wrote: > On Mon, Dec 12, 2016 at 11:08 AM, Eryu Guan wrote: > > On Mon, Dec 12, 2016 at 10:45:06AM +0200, Amir Goldstein wrote: > >> Introduce a new test to demonstrate a known issue with overlayfs: > >> - stat file A shows inode number X > >> - modify A to trigger copy up > >> - stat file A shows inode number Y != X > >> > >> Also test if d_ino of readdir entries changes after copy up. > >> > >> There is a POC patch by Miklos Szeredi that fixes this issue. > >> > >> Not dealing with hardlinks here, because there is more to test > >> then stable inode number. > >> Hardlinks will get a test of their own. > > > > Thanks! I added the missing SOB line, and added "copyup" group too. > > > > Right. Thanks. > I audited existing tests and I believe my 016 also calls for "copyup" tag > and 013 as well. > Do you want a patch for that or will you fix it up yourself? Please send a new patch to fix them. Thanks! Eryu