From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 00/11] overlayfs constant inode numbers
Date: Tue, 25 Apr 2017 07:52:57 -0400 [thread overview]
Message-ID: <20170425115257.GA11500@redhat.com> (raw)
In-Reply-To: <1493025256-27188-1-git-send-email-amir73il@gmail.com>
On Mon, Apr 24, 2017 at 12:14:05PM +0300, Amir Goldstein wrote:
> Miklos,
>
> Following your comments on the 'stable inodes' series from last week,
> this series fixes constant inode numbers for stat(2) with any layer
> configuration.
>
> For the case of all *lower* layers on same fs that supports NFS export,
> redirect by file handle will be used to optimize the lookup of the copy
> up origin of non-dir inode.
>
> For the case of *all* layers on same fs, overlayfs also gains:
> - Persistent inode numbers for directories
> - Correct results for du -x
>
> Consistcy of stat(2) st_ino with readdir(3) d_ino is NOT addressed by
> this series. It will be addressed for the 'samefs' configuration by the
> follow up 'stable inode' work, which is also going to address preserving
> hardlinks on copy up.
Hi Amir,
We need to update Documentation/filesystems/overlayfs.txt as well to
reflect new semantics of reporting st_dev and st_ino?
Vivek
next prev parent reply other threads:[~2017-04-25 11:52 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 9:14 [PATCH v2 00/11] overlayfs constant inode numbers Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 01/11] ovl: store path type in dentry Amir Goldstein
2017-04-24 12:59 ` Vivek Goyal
2017-04-24 13:10 ` Amir Goldstein
2017-04-24 13:36 ` Vivek Goyal
2017-04-24 13:41 ` Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 02/11] ovl: cram opaque boolean into type flags Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 03/11] ovl: check if all layers are on the same fs Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 04/11] ovl: store file handle of lower inode on copy up Amir Goldstein
2017-04-24 13:32 ` kbuild test robot
2017-04-24 13:57 ` Amir Goldstein
2017-04-25 14:53 ` Miklos Szeredi
2017-04-26 5:47 ` Amir Goldstein
2017-04-26 9:21 ` Miklos Szeredi
2017-04-26 9:27 ` Amir Goldstein
2017-04-26 9:35 ` Miklos Szeredi
2017-04-26 9:39 ` Miklos Szeredi
2017-04-26 9:53 ` Amir Goldstein
2017-04-26 9:57 ` Miklos Szeredi
2017-04-24 9:14 ` [PATCH v2 05/11] ovl: lookup redirect by file handle Amir Goldstein
2017-04-25 8:10 ` Amir Goldstein
2017-04-25 15:13 ` Miklos Szeredi
2017-04-25 17:41 ` Amir Goldstein
2017-04-25 19:11 ` Amir Goldstein
2017-04-26 9:06 ` Miklos Szeredi
2017-04-26 9:40 ` Amir Goldstein
2017-04-26 9:55 ` Miklos Szeredi
2017-04-26 10:17 ` Amir Goldstein
2017-04-26 12:15 ` Miklos Szeredi
2017-04-26 14:51 ` Amir Goldstein
2017-04-27 6:27 ` Amir Goldstein
2017-04-27 7:48 ` Miklos Szeredi
2017-04-27 9:22 ` Amir Goldstein
2017-04-27 9:26 ` Miklos Szeredi
[not found] ` <CAOQ4uxiweaqzR3eT-StgtDFAHBuYhGRvAJE6v=XpH33MevpmoA@mail.gmail.com>
[not found] ` <CAJfpegtTJmcLVrLOeQbhu4Q6sM0Mi_FRgr+vStF0k95QsWm5uQ@mail.gmail.com>
2017-04-27 13:53 ` Amir Goldstein
2017-04-27 14:46 ` Miklos Szeredi
2017-04-27 16:08 ` Amir Goldstein
2017-04-28 7:25 ` Amir Goldstein
2017-04-28 7:55 ` Miklos Szeredi
2017-04-28 8:15 ` Amir Goldstein
2017-04-28 9:37 ` Miklos Szeredi
2017-04-28 9:57 ` Amir Goldstein
2017-04-28 10:05 ` Miklos Szeredi
2017-04-28 10:45 ` Amir Goldstein
2017-04-27 7:40 ` Miklos Szeredi
2017-04-24 9:14 ` [PATCH v2 06/11] ovl: lookup non-dir inode copy up origin Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 07/11] ovl: set the COPYUP type flag for non-dirs Amir Goldstein
2017-04-26 14:40 ` Miklos Szeredi
2017-04-26 14:53 ` Miklos Szeredi
2017-04-26 15:02 ` Amir Goldstein
2017-04-26 18:51 ` Amir Goldstein
2017-04-27 9:32 ` Miklos Szeredi
2017-04-26 14:57 ` Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 08/11] ovl: redirect non-dir by path on rename Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 09/11] ovl: constant st_ino/st_dev across copy up Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 10/11] ovl: persistent and constant inode number for directories Amir Goldstein
2017-04-24 9:14 ` [PATCH v2 11/11] ovl: fix du --one-file-system on overlay mount Amir Goldstein
2017-04-24 18:40 ` [PATCH v2 12/12] ovl: persistent inode numbers for hardlinks Amir Goldstein
2017-04-24 18:51 ` [PATCH v2 00/11] overlayfs constant inode numbers Amir Goldstein
2017-04-25 11:52 ` Vivek Goyal [this message]
2017-04-25 12:05 ` Amir Goldstein
2017-04-25 12:16 ` Vivek Goyal
2017-04-25 12:41 ` Amir Goldstein
2017-04-25 12:52 ` Vivek Goyal
2017-04-25 13:23 ` Amir Goldstein
2017-04-25 13:29 ` Vivek Goyal
2017-04-25 13:49 ` Amir Goldstein
2017-04-25 13:53 ` Vivek Goyal
2017-04-25 14:20 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425115257.GA11500@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox