From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: two questiones about overlayfs Date: Wed, 16 Aug 2017 09:52:58 -0400 Message-ID: <20170816135258.GC23045@redhat.com> References: <20170815133554.GB29201@veci.piliscsaba.szeredi.hu> <20170815155617.GC3551@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbdHPNw7 (ORCPT ); Wed, 16 Aug 2017 09:52:59 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-unionfs-owner@vger.kernel.org List-Id: linux-unionfs@vger.kernel.org To: Miklos Szeredi Cc: Amir Goldstein , "zhangyi (F)" , overlayfs , miaoxie@huawei.com, Theodore Tso On Wed, Aug 16, 2017 at 12:19:22PM +0200, Miklos Szeredi wrote: > On Tue, Aug 15, 2017 at 6:16 PM, Amir Goldstein wrote: > > On Tue, Aug 15, 2017 at 5:56 PM, Vivek Goyal wrote: > > >> IIUC, so now "chattr -p " will fail on overlayfs (assume file has not > >> been copied up yet). > >> > > > > Yap. > > > >> IOW, on overlayfs, will it be responsibility of user space to make > >> sure file has been copied up, for chattr operation to succeed? Does that > >> mean we need to modify chattr to open file for WRITE instead of READ. > >> > > > > I guess that would make sense. > > I only wonder what was the reason for chattr to open RDONLY in > > the first place (cc Ted)?? > > What about copy up of flags? Should we? Does reflink copy the flags? Oh yes, copy up of flags seem to be an issue too. I have a file on lower with project id 123 and once that file gets copied up, project id goes back to 0. [merged]# lsattr -p foo.txt 123 ------------------- foo.txt [merged]# touch foo.txt [merged]# lsattr -p foo.txt 0 ------------------- foo.txt Vivek