From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 2/4] overlay: use default overlay mount options _overlay_mount_dirs()
Date: Wed, 27 Sep 2017 16:05:49 +0800 [thread overview]
Message-ID: <20170927080549.GM8034@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOQ4uxhr+1g0Pa8-UPTfG2k-ebU1aCygsXfwmFjjgrpf-gFq2Q@mail.gmail.com>
On Wed, Sep 27, 2017 at 10:50:46AM +0300, Amir Goldstein wrote:
> On Wed, Sep 27, 2017 at 10:04 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> > Tests that use _overlay_mount_dirs() should also use the
> > default overlay mount options.
>
> Vivek, Eryu,
>
> I should make a disclaimer here: I did not test with SELINUX_MOUNT_OPTIONS
> because I have no SELinux in my test setup.
>
> Specifically, I am concerned that tests that compose "special" overlay mounts,
> like tmpfs mounts and stacked overlay mounts (overlay/029) may not play well
> with SELINUX_MOUNT_OPTIONS applied to the special mounts.
> I am less concerned about the tests that were converted to use
> _overlay_scratch_mount_dirs() helper.
>
> Can either of you run a -g overlay/quick test with this series and valid
> SELINUX_MOUNT_OPTIONS?
Sure, I'll do the testings anyway, and I have selinux enabled on my test
vms.
I noticed the overlay mount option mess too when I was reviewing
MOUNT_OPTIONS fixes for btrfs from Gu Jinxiang last week. I was hoping
to refactor the whole mount option handling through fstests. Perhaps
this patchset is good start toward that direction. I'll test and review
them. Thanks!
Eryu
next prev parent reply other threads:[~2017-09-27 8:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 7:04 [PATCH 0/4] fstests: fixes for config option OVERLAY_MOUNT_OPTIONS Amir Goldstein
2017-09-27 7:04 ` [PATCH 1/4] overlay: remove stale implementation of _scratch_mount_options Amir Goldstein
2017-09-27 7:04 ` [PATCH 2/4] overlay: use default overlay mount options _overlay_mount_dirs() Amir Goldstein
2017-09-27 7:50 ` Amir Goldstein
2017-09-27 8:05 ` Eryu Guan [this message]
2017-10-12 6:08 ` Eryu Guan
2017-10-11 11:33 ` Eryu Guan
2017-09-27 7:04 ` [PATCH 3/4] overlay: create helper _overlay_scratch_mount_dirs() Amir Goldstein
2017-09-27 7:04 ` [PATCH 4/4] overlay: fix _overlay_config_override of MOUNT_OPTIONS Amir Goldstein
2017-10-11 11:50 ` Eryu Guan
2017-10-11 12:35 ` Amir Goldstein
2017-09-27 10:47 ` [PATCH 5/5] overlay: move _overlay helpers to common/overlay Amir Goldstein
2017-09-28 11:55 ` [PATCH 6/6] overlay: deduplicate code in overlay mount helpers Amir Goldstein
2017-09-29 1:44 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927080549.GM8034@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).