From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH 3/8] ovl: Provide a mount option metacopy=on/off for metadata copyup
Date: Mon, 9 Oct 2017 10:53:59 -0400 [thread overview]
Message-ID: <20171009145359.GA2485@redhat.com> (raw)
In-Reply-To: <CAOQ4uxiP+QjNW7P1n0-wK-PEVUYCZR_gLd3_H_ZbhC=B5fQvmg@mail.gmail.com>
On Fri, Oct 06, 2017 at 10:01:47PM +0300, Amir Goldstein wrote:
[..]
> > @@ -441,6 +461,12 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
> > config->workdir = NULL;
> > }
> >
> > + /* As of now metacopy=on is dependent on index=on */
> > + if (config->metacopy && !config->index) {
> > + pr_warn("overlayfs: can not enable metadata only copyup with index=off. Falling back to metacopy=off\n");
> > + config->metacopy = false;
> > + }
> > +
>
> There are later places in fill_super where index may be falling back to off
> due to missing file handle support in lower fs.
> Please move this check to much later to make sure metacopy=on and index=off
> cannot co-exists.
Sure, I missed that. Will fix it.
Vivek
next prev parent reply other threads:[~2017-10-09 14:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 17:47 [RFC PATCH 0/8][V2] overlayfs: Delayed copy up of data Vivek Goyal
2017-10-06 17:47 ` [PATCH 1/8] ovl: ovl_check_setxattr() get rid of redundant -EOPNOTSUPP check Vivek Goyal
2017-10-06 17:47 ` [PATCH 2/8] ovl: During copy up, first copy up metadata and then data Vivek Goyal
2017-10-06 17:47 ` [PATCH 3/8] ovl: Provide a mount option metacopy=on/off for metadata copyup Vivek Goyal
2017-10-06 19:01 ` Amir Goldstein
2017-10-09 14:53 ` Vivek Goyal [this message]
2017-10-06 17:47 ` [PATCH 4/8] ovl: Copy up only metadata during copy up where it makes sense Vivek Goyal
2017-10-06 17:47 ` [PATCH 5/8] ovl: Set xattr OVL_XATTR_METACOPY on upper file Vivek Goyal
2017-10-06 17:47 ` [PATCH 6/8] ovl: Set OVL_METACOPY flag during ovl_lookup() Vivek Goyal
2017-10-06 17:47 ` [PATCH 7/8] ovl: Return lower dentry if only metadata copy up took place Vivek Goyal
2017-10-06 17:47 ` [PATCH 8/8] ovl: Fix ovl_getattr() to get number of blocks from lower Vivek Goyal
2017-10-06 18:58 ` Amir Goldstein
2017-10-06 19:01 ` Vivek Goyal
2017-10-06 19:09 ` Amir Goldstein
2017-10-09 14:45 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009145359.GA2485@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).