From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH 09/13] ovl: Set OVL_UPPERDATA flag during ovl_lookup()
Date: Thu, 26 Oct 2017 14:04:18 -0400 [thread overview]
Message-ID: <20171026180418.GE28005@redhat.com> (raw)
In-Reply-To: <CAOQ4uxiKJdJbdBQGipQGCR5ZO=rJXbXJV+zSCwQrkBj7AF-K8Q@mail.gmail.com>
On Thu, Oct 26, 2017 at 09:19:38AM +0300, Amir Goldstein wrote:
[..]
> > @@ -634,6 +653,20 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
> > roe->numlower, &stack, &ctr);
> > if (err)
> > goto out_put_upper;
> > +
> > + err = ovl_check_metacopy(upperdentry);
>
> You should avoid checking metacopy xattr for file types that are not
> eligable.
Sure. Will do.
Vivek
next prev parent reply other threads:[~2017-10-26 18:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 19:09 [RFC PATCH 00/13][V5] overlayfs: Delayed copy up of data Vivek Goyal
2017-10-25 19:09 ` [PATCH 01/13] ovl: Put upperdentry if ovl_check_origin() fails Vivek Goyal
2017-10-25 20:08 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 02/13] ovl: Create origin xattr on copy up for all files Vivek Goyal
2017-10-26 5:31 ` Amir Goldstein
2017-10-26 12:53 ` Vivek Goyal
2017-10-25 19:09 ` [PATCH 03/13] ovl: ovl_check_setxattr() get rid of redundant -EOPNOTSUPP check Vivek Goyal
2017-10-25 19:09 ` [PATCH 04/13] ovl: Provide a mount option metacopy=on/off for metadata copyup Vivek Goyal
2017-10-26 5:39 ` Amir Goldstein
2017-10-26 13:15 ` Vivek Goyal
2017-10-26 13:57 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 05/13] ovl: During copy up, first copy up metadata and then data Vivek Goyal
2017-10-26 5:42 ` Amir Goldstein
2017-10-26 13:19 ` Vivek Goyal
2017-10-25 19:09 ` [PATCH 06/13] ovl: Copy up only metadata during copy up where it makes sense Vivek Goyal
2017-10-25 19:09 ` [PATCH 07/13] ovl: A new xattr OVL_XATTR_METACOPY for file on upper Vivek Goyal
2017-10-26 6:04 ` Amir Goldstein
2017-10-26 13:53 ` Vivek Goyal
2017-10-26 14:14 ` Amir Goldstein
2017-10-26 14:34 ` Vivek Goyal
2017-10-26 16:11 ` Amir Goldstein
2017-10-27 4:28 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 08/13] ovl: Fix ovl_getattr() to get number of blocks from lower Vivek Goyal
2017-10-26 6:12 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 09/13] ovl: Set OVL_UPPERDATA flag during ovl_lookup() Vivek Goyal
2017-10-26 6:19 ` Amir Goldstein
2017-10-26 18:04 ` Vivek Goyal [this message]
2017-10-25 19:09 ` [PATCH 10/13] ovl: Return lower dentry if only metadata copy up took place Vivek Goyal
2017-10-25 19:09 ` [PATCH 11/13] ovl: Introduce read/write barriers around metacopy flag update Vivek Goyal
2017-10-26 6:34 ` Amir Goldstein
2017-10-26 17:54 ` Vivek Goyal
2017-10-27 4:35 ` Amir Goldstein
2017-10-27 13:14 ` Vivek Goyal
2017-10-25 19:09 ` [PATCH 12/13] ovl: Do not export metacopy only upper dentry Vivek Goyal
2017-10-26 6:54 ` Amir Goldstein
2017-10-26 6:54 ` Amir Goldstein
2017-10-25 19:09 ` [PATCH 13/13] ovl: Enable metadata only feature Vivek Goyal
2017-10-26 7:07 ` Amir Goldstein
2017-10-26 18:19 ` Vivek Goyal
2017-10-26 7:18 ` [RFC PATCH 00/13][V5] overlayfs: Delayed copy up of data Amir Goldstein
2017-10-27 16:40 ` Vivek Goyal
2017-10-28 14:50 ` Amir Goldstein
2017-10-31 13:39 ` Vivek Goyal
2017-10-31 13:56 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026180418.GE28005@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).