Re: [PATCH 13/13] ovl: Enable metadata only feature

[Vivek Goyal <vgoyal@redhat.com>]

On Thu, Oct 26, 2017 at 10:07:39AM +0300, Amir Goldstein wrote:
> On Wed, Oct 25, 2017 at 10:09 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
> > All the bits are in patches before this. So it is time to enable the
> > metadata only copy up feature.
> >
> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> > ---
> >  fs/overlayfs/copy_up.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
> > index 4876ae4..3ce35e1 100644
> > --- a/fs/overlayfs/copy_up.c
> > +++ b/fs/overlayfs/copy_up.c
> > @@ -637,12 +637,13 @@ static int ovl_copy_up_one(struct dentry *parent, struct dentry *dentry,
> >         int err;
> >         DEFINE_DELAYED_CALL(done);
> >         struct path parentpath;
> > +       struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
> >         struct ovl_copy_up_ctx ctx = {
> >                 .parent = parent,
> >                 .dentry = dentry,
> >                 .workdir = ovl_workdir(dentry),
> >                 .origin = true,
> > -               .metacopy = false,
> > +               .metacopy = ofs->config.metacopy,
> 
> This should have been better
> .metacopy = ovl_dentry_needs_data_copy_up(dentry)

You mean ovl_dentry_needs_meta_copy_up(). Ok, I will introduce a
helper for this and get rid of other code.

> to begin with and the helper would start with
> 
> if (true) return; (with a TODO comment)
> 
> That this patch would fix to
> if (!ofs->config.metacopy) return
> 
> Then you don't need to check ISREG and write flags below.

Will do.

Vivek