From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v8 0/9] Overlayfs: constant st_ino/d_ino for non-samefs
Date: Tue, 7 Nov 2017 14:39:46 -0500 [thread overview]
Message-ID: <20171107193946.GC3646@redhat.com> (raw)
In-Reply-To: <1510073889-11657-1-git-send-email-amir73il@gmail.com>
Hi Miklos,
These patches apply on top of which tree/branch. I am trying linus's
latest tree and these fail to apply.
Vivek
On Tue, Nov 07, 2017 at 06:58:00PM +0200, Amir Goldstein wrote:
> Miklos,
>
> This version provides a solution for some interesting non-samefs cases:
> - All the ext* family
> - Many other fs with default encode_fh
> - xfs that is not huge with overlay 'xino' mount option
> - tmpfs that is not on a machine with jurassic uptime with 'xino'
>
> I tested this with Chandan's upstream overlay/041 xfstest for
> consistent d_ino in non-samefs setup. Results are:
> - Test passes for ext4
> - Test fails for xfs
> - Test fails for xfs with OVERLAY_MOUNT_OPTIONS=-oxino,
> but this is because of a test bug
> - With the test bug fix available at [2] test passes
> with xfs and OVERLAY_MOUNT_OPTIONS=-oxino
>
> All the exportfs tests also pass with these changes and
> either ext4 or xfs with OVERLAY_MOUNT_OPTIONS=-oxino.
>
> Changes since v7:
> - Drop patches for building impure cache for non-samefs subdirs
> - Dropped patch "update cache version of impure parent on rename"
> because it is not relevant to this series
> - Remap lower inode numbers for 32bit inode file systems
> - Add mount option 'xino' for opting-in to use high inode bits
>
> Thanks,
> Amir.
>
> [1] https://github.com/amir73il/linux/commits/ovl-nonsamefs-v8
> [2] https://github.com/amir73il/xfstests/commits/overlayfs-devel
>
> Amir Goldstein (8):
> ovl: move include of ovl_entry.h into overlayfs.h
> ovl: allocate anonymous devs for lowerdirs
> ovl: factor out ovl_map_dev_ino() helper
> ovl: return anonymous st_dev for lower inodes
> ovl: relax same fs constraint for constant st_ino
> ovl: constant st_ino for non-samefs with xino
> ovl: consistent d_ino for non-samefs with xino
> ovl: add support for 'xino' mount option
>
> Chandan Rajendra (1):
> ovl: re-structure overlay lower layers in-memory
>
> fs/overlayfs/copy_up.c | 1 -
> fs/overlayfs/inode.c | 91 +++++++++++++++++++++++++--------
> fs/overlayfs/namei.c | 42 +++++++--------
> fs/overlayfs/overlayfs.h | 9 ++--
> fs/overlayfs/ovl_entry.h | 19 ++++++-
> fs/overlayfs/readdir.c | 49 +++++++++++++++---
> fs/overlayfs/super.c | 129 +++++++++++++++++++++++++++++++++--------------
> fs/overlayfs/util.c | 39 ++++++++++++--
> 8 files changed, 277 insertions(+), 102 deletions(-)
>
> --
> 2.7.4
next prev parent reply other threads:[~2017-11-07 19:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 16:58 [PATCH v8 0/9] Overlayfs: constant st_ino/d_ino for non-samefs Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 1/9] ovl: move include of ovl_entry.h into overlayfs.h Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 2/9] ovl: re-structure overlay lower layers in-memory Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 3/9] ovl: allocate anonymous devs for lowerdirs Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 4/9] ovl: factor out ovl_map_dev_ino() helper Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 5/9] ovl: return anonymous st_dev for lower inodes Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 6/9] ovl: relax same fs constraint for constant st_ino Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 7/9] ovl: constant st_ino for non-samefs with xino Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 8/9] ovl: consistent d_ino " Amir Goldstein
2017-11-07 16:58 ` [PATCH v8 9/9] ovl: add support for 'xino' mount option Amir Goldstein
2017-11-07 19:39 ` Vivek Goyal [this message]
2017-11-07 19:56 ` [PATCH v8 0/9] Overlayfs: constant st_ino/d_ino for non-samefs Amir Goldstein
2017-11-08 10:53 ` Miklos Szeredi
2017-11-08 12:01 ` Amir Goldstein
2017-11-08 13:40 ` Amir Goldstein
2017-11-08 16:50 ` Amir Goldstein
2017-11-09 9:33 ` Miklos Szeredi
2017-11-09 11:25 ` Amir Goldstein
2017-11-10 9:24 ` Amir Goldstein
2017-11-08 18:16 ` Amir Goldstein
2018-03-17 8:29 ` Amir Goldstein
2018-03-22 14:19 ` Miklos Szeredi
2018-03-22 15:07 ` Amir Goldstein
2018-03-22 15:36 ` Miklos Szeredi
2018-03-23 14:00 ` Vivek Goyal
2018-03-23 16:05 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107193946.GC3646@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).