From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
fstests <fstests@vger.kernel.org>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] overlay/038: code cleanup
Date: Tue, 21 Nov 2017 15:18:26 +0800 [thread overview]
Message-ID: <20171121071826.GN2749@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOQ4uxg7HwRQ8P5ywrfq=s4NTDRavinoX3BMNyWOBQL9Pj6n-A@mail.gmail.com>
On Tue, Nov 21, 2017 at 08:33:53AM +0200, Amir Goldstein wrote:
> On Mon, Nov 20, 2017 at 4:34 PM, Chandan Rajendra
> <chandan@linux.vnet.ibm.com> wrote:
> > This commit implements similar changes made to overlay/041 test i.e.
> > - Remove duplicate merged dir tests
> > - Remove duplicate pure upper dir inside merged dir tests
> > - Sort out comments and error messages
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>
> Looks good and tested.
>
> Nit: one trailing whitespace in this patch.
> Applying: overlay/038: code cleanup
> .git/rebase-apply/patch:114: trailing whitespace.
>
> warning: 1 line adds whitespace errors.
I can fix that up on commit. Thanks for the review!
Eryu
prev parent reply other threads:[~2017-11-21 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 14:34 [PATCH 1/2] overlay/038: code cleanup Chandan Rajendra
2017-11-20 14:34 ` [PATCH 2/2] overlay/038: test consistent values of st_ino/d_ino for subdirs Chandan Rajendra
2017-11-21 6:30 ` Amir Goldstein
2017-11-21 6:33 ` [PATCH 1/2] overlay/038: code cleanup Amir Goldstein
2017-11-21 7:18 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121071826.GN2749@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).