From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH xfstest v2 2/4] overlay: add fsck.overlay whiteout test Date: Tue, 2 Jan 2018 15:05:01 -0500 Message-ID: <20180102200501.GD15274@redhat.com> References: <20171228114933.47759-1-yi.zhang@huawei.com> <20171228114933.47759-3-yi.zhang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171228114933.47759-3-yi.zhang@huawei.com> Sender: fstests-owner@vger.kernel.org To: "zhangyi (F)" Cc: linux-unionfs@vger.kernel.org, fstests@vger.kernel.org, miklos@szeredi.hu, amir73il@gmail.com, eguan@redhat.com, miaoxie@huawei.com, yangerkun@huawei.com List-Id: linux-unionfs@vger.kernel.org On Thu, Dec 28, 2017 at 07:49:31PM +0800, zhangyi (F) wrote: [..] > +# Create test directories > +lowerdir=$OVL_BASE_SCRATCH_MNT/lower > +lowerdir2=$OVL_BASE_SCRATCH_MNT/lower2 > +upperdir=$OVL_BASE_SCRATCH_MNT/upper > +workdir=$OVL_BASE_SCRATCH_MNT/workdir > + > +mkdir -p $lowerdir $lowerdir2 $upperdir $workdir $workdir Minor nit. Why $workdir has been specified twice. I saw it in another test as well. Vivek