From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH xfstest v2 2/4] overlay: add fsck.overlay whiteout test Date: Wed, 3 Jan 2018 10:04:35 -0500 Message-ID: <20180103150435.GA3595@redhat.com> References: <20171228114933.47759-1-yi.zhang@huawei.com> <20171228114933.47759-3-yi.zhang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48694 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbeACPEg (ORCPT ); Wed, 3 Jan 2018 10:04:36 -0500 Content-Disposition: inline In-Reply-To: <20171228114933.47759-3-yi.zhang@huawei.com> Sender: linux-unionfs-owner@vger.kernel.org List-Id: linux-unionfs@vger.kernel.org To: "zhangyi (F)" Cc: linux-unionfs@vger.kernel.org, fstests@vger.kernel.org, miklos@szeredi.hu, amir73il@gmail.com, eguan@redhat.com, miaoxie@huawei.com, yangerkun@huawei.com On Thu, Dec 28, 2017 at 07:49:31PM +0800, zhangyi (F) wrote: [..] > +# Test orphan whiteout in lower and upper layer, should remove > +echo "+ Orphan whiteout" > +make_whiteout $lowerdir/foo > +make_whiteout $upperdir/foo > +make_whiteout $upperdir/bar > + > +_overlay_fsck_dirs $lowerdir $upperdir $workdir -p >> $seqres.full 2>&1 || \ > + _fail "fsck should not fail" I ran fsck.overlay manually (V3 patches) with one orphan whiteout in upper. I get following output. fsck.overlay -o lowerdir=lower,upperdir=upper,workdir=work Orphan whiteout: /root/fsck-overlay-testing/upper/foo Remove ? [y]: y fsck.overlay:[Error]: Cannot getxattr /root/fsck-overlay-testing/upper/foo trusted.overlay.origin: No such file or directory Filesystem clean This message about "overlay.origin" not being there, should not be an error. You have already figured out, its an orphan whiteout, and user already asked you to remove it. So checking or origin after that can calling it Error might not make much sense. Also on top, later I get "Filesystem clean". I think in this case, user should not see any message until and unless a error actually has happened which prevents from cleaning orphan whiteout. Vivek