Re: [PATCH v2 14/23] ovl: index all files on copy up with 'verify=on'

[Vivek Goyal <vgoyal@redhat.com>]

On Thu, Jan 04, 2018 at 06:40:09PM +0200, Amir Goldstein wrote:
> With the 'verify' feature enabled, all files are indexed on copy up.
> The copy up origin inode of an indexed non-dir can be used as a unique
> identifier of the overlay object.
> 
> This is going to be used for NFS export.
> 
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
>  fs/overlayfs/util.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c
> index 0254d7f0d401..f40351dcea7b 100644
> --- a/fs/overlayfs/util.c
> +++ b/fs/overlayfs/util.c
> @@ -491,6 +491,10 @@ bool ovl_need_index(struct dentry *dentry)
>  	if (!lower || !ovl_indexdir(dentry->d_sb))
>  		return false;
>  
> +	/* Index all files for unique origin verification */
> +	if (!d_is_dir(lower) && ovl_verify(dentry->d_sb))
> +		return true;

If all files are indexd up with verify=on, what is this check about
"!d_is_dir()"?

Vivek

> +
>  	/* Index only lower hardlinks on copy up */
>  	if (!d_is_dir(lower) && d_inode(lower)->i_nlink > 1)
>  		return true;
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html