From: Vivek Goyal <vgoyal@redhat.com>
To: linux-unionfs@vger.kernel.org
Cc: miklos@szeredi.hu, amir73il@gmail.com, vgoyal@redhat.com
Subject: [PATCH 3/3] ovl: set d->is_dir and d->opaque for last path element
Date: Thu, 8 Mar 2018 17:18:04 -0500 [thread overview]
Message-ID: <20180308221804.15708-4-vgoyal@redhat.com> (raw)
In-Reply-To: <20180308221804.15708-1-vgoyal@redhat.com>
Certain properties in ovl_lookup_data should be set only for the last
element of the path. IOW, of we are calling ovl_lookup_single() for an
absolute redirect, then d->is_dir and d->opaque do not make much sense
for intermediate path elements. Instead set them only if dentry being
lookup is last path element.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
fs/overlayfs/namei.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
index 32d1d96f80b6..dfefe6277659 100644
--- a/fs/overlayfs/namei.c
+++ b/fs/overlayfs/namei.c
@@ -220,6 +220,7 @@ static int ovl_lookup_single(struct dentry *base, struct ovl_lookup_data *d,
{
struct dentry *this;
int err;
+ bool last_element = !post[0];
this = lookup_one_len_unlocked(name, base, namelen);
if (IS_ERR(this)) {
@@ -247,9 +248,10 @@ static int ovl_lookup_single(struct dentry *base, struct ovl_lookup_data *d,
goto put_and_out;
goto out;
}
- d->is_dir = true;
+ if (last_element)
+ d->is_dir = true;
if (!d->last) {
- if (ovl_is_opaquedir(this)) {
+ if (last_element && ovl_is_opaquedir(this)) {
d->stop = d->opaque = true;
goto out;
}
--
2.13.6
next prev parent reply other threads:[~2018-03-08 22:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 22:18 [RFC PATCH 0/3] Misc ovl_lookup() related fixes Vivek Goyal
2018-03-08 22:18 ` [PATCH 1/3] ovl: Set d->last properly during lookup Vivek Goyal
2018-03-08 22:25 ` Amir Goldstein
2018-03-09 14:08 ` Vivek Goyal
2018-03-08 22:18 ` [PATCH 2/3] ovl: Do not check for redirect if this is last layer Vivek Goyal
2018-03-08 22:27 ` Amir Goldstein
2018-03-09 14:18 ` Vivek Goyal
2018-03-08 22:18 ` Vivek Goyal [this message]
2018-03-08 22:34 ` [PATCH 3/3] ovl: set d->is_dir and d->opaque for last path element Amir Goldstein
2018-03-09 14:44 ` Vivek Goyal
2018-03-09 15:20 ` Amir Goldstein
2018-03-09 16:30 ` Vivek Goyal
2018-03-09 16:38 ` Amir Goldstein
2018-03-09 16:44 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308221804.15708-4-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox