linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
	fstests <fstests@vger.kernel.org>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH V2] xfstest: overlay: Add tests for overlay metadata only copy up feature
Date: Fri, 11 May 2018 18:41:56 +0800	[thread overview]
Message-ID: <20180511104156.GO8373@desktop> (raw)
In-Reply-To: <CAOQ4uxgRb0T6nWou7uasOF+QGEHRMa1C5wD4AsJABJDXK+yNhQ@mail.gmail.com>

On Wed, May 09, 2018 at 07:22:48PM +0300, Amir Goldstein wrote:
> On Wed, May 9, 2018 at 6:27 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
> > Hi,
> >
> > Please find attached the V2 of the patch. Took care of Amir's comments
> > from previous version.
> >
> > Add tests for metadata only copy up feature.
> >
> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> 
> Looks good.
> 
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>

Thanks for the review!

> 
> Just a note to Eryu -
> 
> You may want to hold on to this test until metacopy is merged
> or at least staged on Miklos' next branch.

I'd wait for the patches hit Miklos' tree.

Thanks,
Eryu

  reply	other threads:[~2018-05-11 10:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 15:27 [PATCH V2] xfstest: overlay: Add tests for overlay metadata only copy up feature Vivek Goyal
2018-05-09 16:22 ` Amir Goldstein
2018-05-11 10:41   ` Eryu Guan [this message]
2018-05-29 17:08     ` Amir Goldstein
2018-05-29 18:52       ` Vivek Goyal
2018-05-29 19:11         ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180511104156.GO8373@desktop \
    --to=guaneryu@gmail.com \
    --cc=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).