* Re: [PATCH 03/16] vfs: don't evict uninitialized inode [not found] ` <CAOQ4uxjHdtjc-aXHb-kxghAxU1oRbhEHmBVX5+=w8CgcnGBSGg@mail.gmail.com> @ 2018-08-24 6:47 ` Amir Goldstein 2018-10-08 6:41 ` Miklos Szeredi 0 siblings, 1 reply; 3+ messages in thread From: Amir Goldstein @ 2018-08-24 6:47 UTC (permalink / raw) To: Greg KH; +Cc: Al Viro, linux-fsdevel, overlayfs, stable, Miklos Szeredi > Miklos, > > Seeing that it wasn't fixed in 4.18.. > > > I've nothing against applying "new primitive: discard_new_inode() now > > + this patch, but if it is deemed too risky at this point, we could > > just revert the buggy commit 80ea09a002bf ("vfs: factor out > > inode_insert5()") and its dependencies. > > > > Should we propose for stable the upstream commits: > e950564b97fd vfs: don't evict uninitialized inode > c2b6d621c4ff new primitive: discard_new_inode() > > Or should we go with the independent v1 patch: > https://patchwork.kernel.org/patch/10511969/ > Greg, To fix a 4.18 overlayfs regression please apply the following 3 upstream commits (in apply order): c2b6d621c4ff new primitive: discard_new_inode() e950564b97fd vfs: don't evict uninitialized inode 6faf05c2b2b4 ovl: set I_CREATING on inode being created Thanks, Amir. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 03/16] vfs: don't evict uninitialized inode 2018-08-24 6:47 ` [PATCH 03/16] vfs: don't evict uninitialized inode Amir Goldstein @ 2018-10-08 6:41 ` Miklos Szeredi 2018-10-08 13:23 ` Greg KH 0 siblings, 1 reply; 3+ messages in thread From: Miklos Szeredi @ 2018-10-08 6:41 UTC (permalink / raw) To: Amir Goldstein; +Cc: Greg KH, Al Viro, linux-fsdevel, overlayfs, stable On Fri, Aug 24, 2018 at 8:47 AM, Amir Goldstein <amir73il@gmail.com> wrote: >> Miklos, >> >> Seeing that it wasn't fixed in 4.18.. >> >> > I've nothing against applying "new primitive: discard_new_inode() now >> > + this patch, but if it is deemed too risky at this point, we could >> > just revert the buggy commit 80ea09a002bf ("vfs: factor out >> > inode_insert5()") and its dependencies. >> > >> >> Should we propose for stable the upstream commits: >> e950564b97fd vfs: don't evict uninitialized inode >> c2b6d621c4ff new primitive: discard_new_inode() >> >> Or should we go with the independent v1 patch: >> https://patchwork.kernel.org/patch/10511969/ >> > > Greg, > > To fix a 4.18 overlayfs regression please apply the following > 3 upstream commits (in apply order): > > c2b6d621c4ff new primitive: discard_new_inode() > e950564b97fd vfs: don't evict uninitialized inode > 6faf05c2b2b4 ovl: set I_CREATING on inode being created Is this fixed in 4.18.z yet? Thanks, Miklos ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 03/16] vfs: don't evict uninitialized inode 2018-10-08 6:41 ` Miklos Szeredi @ 2018-10-08 13:23 ` Greg KH 0 siblings, 0 replies; 3+ messages in thread From: Greg KH @ 2018-10-08 13:23 UTC (permalink / raw) To: Miklos Szeredi; +Cc: Amir Goldstein, Al Viro, linux-fsdevel, overlayfs, stable On Mon, Oct 08, 2018 at 08:41:13AM +0200, Miklos Szeredi wrote: > On Fri, Aug 24, 2018 at 8:47 AM, Amir Goldstein <amir73il@gmail.com> wrote: > >> Miklos, > >> > >> Seeing that it wasn't fixed in 4.18.. > >> > >> > I've nothing against applying "new primitive: discard_new_inode() now > >> > + this patch, but if it is deemed too risky at this point, we could > >> > just revert the buggy commit 80ea09a002bf ("vfs: factor out > >> > inode_insert5()") and its dependencies. > >> > > >> > >> Should we propose for stable the upstream commits: > >> e950564b97fd vfs: don't evict uninitialized inode > >> c2b6d621c4ff new primitive: discard_new_inode() > >> > >> Or should we go with the independent v1 patch: > >> https://patchwork.kernel.org/patch/10511969/ > >> > > > > Greg, > > > > To fix a 4.18 overlayfs regression please apply the following > > 3 upstream commits (in apply order): > > > > c2b6d621c4ff new primitive: discard_new_inode() > > e950564b97fd vfs: don't evict uninitialized inode > > 6faf05c2b2b4 ovl: set I_CREATING on inode being created > > Is this fixed in 4.18.z yet? Not yet, sorry, will try to get to that today... greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-08 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180729220317.GB30522@ZenIV.linux.org.uk>
[not found] ` <20180729220453.13431-1-viro@ZenIV.linux.org.uk>
[not found] ` <20180729220453.13431-3-viro@ZenIV.linux.org.uk>
[not found] ` <CAOQ4uxgOLEpaZ=UwA_CG6CzYbsJBPV4unEV9D5mXrooLXO0+0w@mail.gmail.com>
[not found] ` <CAOssrKfmR0beT4dXjg1dn6DBsPbmGBpS5xHpG9QtAAEgMWo_Xg@mail.gmail.com>
[not found] ` <CAOQ4uxjHdtjc-aXHb-kxghAxU1oRbhEHmBVX5+=w8CgcnGBSGg@mail.gmail.com>
2018-08-24 6:47 ` [PATCH 03/16] vfs: don't evict uninitialized inode Amir Goldstein
2018-10-08 6:41 ` Miklos Szeredi
2018-10-08 13:23 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).