* [PATCH] src/fiemap-tester: check for illegal block size
@ 2018-10-11 11:45 Amir Goldstein
0 siblings, 0 replies; only message in thread
From: Amir Goldstein @ 2018-10-11 11:45 UTC (permalink / raw)
To: Eryu Guan; +Cc: Miklos Szeredi, linux-unionfs, fstests
There was a regression in v4.19-rc1 that caused FIGETBSZ ioctl
to return 0 on an overlayfs file.
That regression went unnoticed because the xfstests that run
fiemap-tester program terminated in success status after not doing
much instead of failing.
Check for invalid value of block size returned by FIGETBSZ ioctl,
so these tests can detect the regression.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
src/fiemap-tester.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/fiemap-tester.c b/src/fiemap-tester.c
index 97ac5ad0..5b0af478 100644
--- a/src/fiemap-tester.c
+++ b/src/fiemap-tester.c
@@ -561,6 +561,12 @@ main(int argc, char **argv)
exit(1);
}
+ if (blocksize <= 0) {
+ printf("Illegal filesystem block size\n");
+ close(fd);
+ exit(1);
+ }
+
#ifdef HAVE_FALLOCATE
/* if fallocate passes, then we can do preallocation, else not */
if (prealloc) {
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-10-11 11:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 11:45 [PATCH] src/fiemap-tester: check for illegal block size Amir Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).