public inbox for linux-unionfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Vivek Goyal <vgoyal@redhat.com>, linux-unionfs@vger.kernel.org
Subject: [PATCH v2 0/5] Overlayfs strict feature requirements
Date: Thu,  1 Nov 2018 02:48:08 +0200	[thread overview]
Message-ID: <20181101004813.31349-1-amir73il@gmail.com> (raw)

Vivek, Miklos,

This series passes overlay/quick xfstests and I verified manually
some expected mount failures with metacopy=on and override with
metacopy=on,strict=off.

Still needs very carefull review and the ovl_check_rename_whiteout()
helper in patch 3 is broken, so I disabled it for now.

Patches 1-3 are marked for stable apply cleanly on v4.19.
Patch 4 doesn't apply to v4.19.
Patch 5 will probably apply, but not sure it is stable material.

I did not change behavior w.r.t enabling of redirect_dir, because
it involves many corner cases and I don't think it matters for stable.
We can always improve it later and let some mount configurations that
used to fail succeed with expected user requested mount options.
When we address the metacopy => redirect_dir dependency, we should also
address the nfs_export => index dependency in a similar manner.

Thanks,
Amir.

Amir Goldstein (5):
  ovl: return error on mount if metacopy cannot be enabled
  ovl: enforce 'strict' feature requirements with metacopy=on
  ovl: enforce 'strict' upper fs requirements with metacopy=on
  ovl: enforce 'strict' unique uuid requirement with metacopy=on
  ovl: enforce 'strict' upper fs and feature requirements with strict=on

 fs/overlayfs/Kconfig     |  23 ++++
 fs/overlayfs/ovl_entry.h |   1 +
 fs/overlayfs/super.c     | 235 ++++++++++++++++++++++++++++++---------
 3 files changed, 208 insertions(+), 51 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-11-01  0:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01  0:48 Amir Goldstein [this message]
2018-11-01  0:48 ` [PATCH v2 1/5] ovl: return error on mount if metacopy cannot be enabled Amir Goldstein
2018-11-01 13:03   ` Vivek Goyal
2018-11-01 13:11     ` Miklos Szeredi
2018-11-01 20:41       ` Miklos Szeredi
2018-11-01 21:22         ` Amir Goldstein
2018-11-01 21:39           ` Miklos Szeredi
2018-11-05 12:57             ` Amir Goldstein
2018-11-07 11:26               ` Miklos Szeredi
2018-11-07 11:59                 ` Amir Goldstein
2018-11-07 12:09                   ` Miklos Szeredi
2018-11-01 21:25         ` Vivek Goyal
2018-11-01 21:35           ` Miklos Szeredi
2018-11-01  0:48 ` [PATCH v2 2/5] ovl: enforce 'strict' feature requirements with metacopy=on Amir Goldstein
2018-11-01  0:48 ` [PATCH v2 3/5] ovl: enforce 'strict' upper fs " Amir Goldstein
2018-11-01  0:48 ` [PATCH v2 4/5] ovl: enforce 'strict' unique uuid requirement " Amir Goldstein
2018-11-01  0:48 ` [PATCH v2 5/5] ovl: enforce 'strict' upper fs and feature requirements with strict=on Amir Goldstein
2018-11-01  7:42 ` [PATCH v2 0/5] Overlayfs strict feature requirements Amir Goldstein
2018-11-01 13:16 ` Vivek Goyal
2018-11-01 13:42   ` Amir Goldstein
2018-11-01 14:02     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181101004813.31349-1-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox