From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Vivek Goyal <vgoyal@redhat.com>, linux-unionfs@vger.kernel.org
Subject: [PATCH v2 4/5] ovl: enforce 'strict' unique uuid requirement with metacopy=on
Date: Thu, 1 Nov 2018 02:48:12 +0200 [thread overview]
Message-ID: <20181101004813.31349-5-amir73il@gmail.com> (raw)
In-Reply-To: <20181101004813.31349-1-amir73il@gmail.com>
With metacopy=on, fail mount instead of disabling index feature on
detection of non unique uuid among underlying filesystems.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
fs/overlayfs/super.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 4aca0cc67455..d848112f4fc9 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1323,6 +1323,12 @@ static int ovl_get_fsid(struct ovl_fs *ofs, const struct path *path)
pr_warn("overlayfs: %s uuid detected in lower fs '%pd2', falling back to index=off,nfs_export=off.\n",
uuid_is_null(&sb->s_uuid) ? "null" : "conflicting",
path->dentry);
+
+ err = ovl_feature_requires(&ofs->config,
+ "NFS export and inode index",
+ "unique uuid with multiple underlying fs");
+ if (err)
+ return err;
}
err = get_anon_bdev(&dev);
--
2.17.1
next prev parent reply other threads:[~2018-11-01 0:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 0:48 [PATCH v2 0/5] Overlayfs strict feature requirements Amir Goldstein
2018-11-01 0:48 ` [PATCH v2 1/5] ovl: return error on mount if metacopy cannot be enabled Amir Goldstein
2018-11-01 13:03 ` Vivek Goyal
2018-11-01 13:11 ` Miklos Szeredi
2018-11-01 20:41 ` Miklos Szeredi
2018-11-01 21:22 ` Amir Goldstein
2018-11-01 21:39 ` Miklos Szeredi
2018-11-05 12:57 ` Amir Goldstein
2018-11-07 11:26 ` Miklos Szeredi
2018-11-07 11:59 ` Amir Goldstein
2018-11-07 12:09 ` Miklos Szeredi
2018-11-01 21:25 ` Vivek Goyal
2018-11-01 21:35 ` Miklos Szeredi
2018-11-01 0:48 ` [PATCH v2 2/5] ovl: enforce 'strict' feature requirements with metacopy=on Amir Goldstein
2018-11-01 0:48 ` [PATCH v2 3/5] ovl: enforce 'strict' upper fs " Amir Goldstein
2018-11-01 0:48 ` Amir Goldstein [this message]
2018-11-01 0:48 ` [PATCH v2 5/5] ovl: enforce 'strict' upper fs and feature requirements with strict=on Amir Goldstein
2018-11-01 7:42 ` [PATCH v2 0/5] Overlayfs strict feature requirements Amir Goldstein
2018-11-01 13:16 ` Vivek Goyal
2018-11-01 13:42 ` Amir Goldstein
2018-11-01 14:02 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101004813.31349-5-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox