Re: [PATCH] overlay: create directory over deleted whiteout

[Eryu Guan <guaneryu@gmail.com>]

On Sun, Nov 11, 2018 at 06:45:25PM +0200, Amir Goldstein wrote:
> On Wed, Oct 31, 2018 at 12:17 PM Amir Goldstein <amir73il@gmail.com> wrote:
> >
> > On Wed, Oct 31, 2018 at 11:55 AM Miklos Szeredi <mszeredi@redhat.com> wrote:
> > >
> > > There's a bug in the overlayfs implementation starting from the very first
> > > merged version that may cause an Oops of various forms if a directory is created
> > > over a whiteout dentry, but the actual whiteout on the upper layer was removed
> > > to the directory creation.
> > >
> > > Reported by: kaixuxia <xiakaixu1987@gmail.com>
> > > Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> > > ---
> >
> > Looks good. A bit of commentary could be useful...
> 
> Eryu,
> 
> I see you have not included this test in today's update.
> Maybe you though that this discussion did not conclude.
> On my part, besides adding the 2 comment lines, there
> are no further concerns.

Yeah, I saw the discussion was on going so I didn't save the thread to
my "to-review" queue and it fell out of my radar.. I'll queue it now.

> 
> FYI, the fix for this bug is now in master:
> 5e1275808630 ovl: check whiteout in ovl_create_over_whiteout()

Thanks for the reminder!

Eryu