From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:37424 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbeKLMHX (ORCPT ); Mon, 12 Nov 2018 07:07:23 -0500 Date: Mon, 12 Nov 2018 10:16:17 +0800 From: Eryu Guan Subject: Re: [PATCH] overlay: create directory over deleted whiteout Message-ID: <20181112021617.GB3889@desktop> References: <20181031095502.12504-1-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-unionfs-owner@vger.kernel.org To: Amir Goldstein Cc: Miklos Szeredi , fstests , overlayfs List-ID: On Sun, Nov 11, 2018 at 06:45:25PM +0200, Amir Goldstein wrote: > On Wed, Oct 31, 2018 at 12:17 PM Amir Goldstein wrote: > > > > On Wed, Oct 31, 2018 at 11:55 AM Miklos Szeredi wrote: > > > > > > There's a bug in the overlayfs implementation starting from the very first > > > merged version that may cause an Oops of various forms if a directory is created > > > over a whiteout dentry, but the actual whiteout on the upper layer was removed > > > to the directory creation. > > > > > > Reported by: kaixuxia > > > Signed-off-by: Miklos Szeredi > > > --- > > > > Looks good. A bit of commentary could be useful... > > Eryu, > > I see you have not included this test in today's update. > Maybe you though that this discussion did not conclude. > On my part, besides adding the 2 comment lines, there > are no further concerns. Yeah, I saw the discussion was on going so I didn't save the thread to my "to-review" queue and it fell out of my radar.. I'll queue it now. > > FYI, the fix for this bug is now in master: > 5e1275808630 ovl: check whiteout in ovl_create_over_whiteout() Thanks for the reminder! Eryu