From: Eryu Guan <guaneryu@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Eddie Horng <eddiehorng.tw@gmail.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] generic/{436,445}: check falloc support
Date: Sat, 2 Mar 2019 23:26:43 +0800 [thread overview]
Message-ID: <20190302152643.GE2824@desktop> (raw)
In-Reply-To: <20190226140902.32219-1-amir73il@gmail.com>
On Tue, Feb 26, 2019 at 04:09:01PM +0200, Amir Goldstein wrote:
> The sanity test case in those tests (i.e. 13..17)
> are all skipped in fs with no falloc support, but the tests
> are reported to pass.
>
> For example, from 445.full:
>
> File system supports the default behavior.
> File system does not support fallocate.
> Allocation size: 4096
> 17. Test file with unwritten extents, data-hole-data inside page
> Test skipped as fs doesn't support unwritten extents.
>
> Explicitly check for falloc support before running those tests
> so they would be properly reported as skipped.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
This patch looks fine, I'm taking it for this week's update.
Thanks,
Eryu
prev parent reply other threads:[~2019-03-02 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:09 [PATCH 1/2] generic/{436,445}: check falloc support Amir Goldstein
2019-02-26 14:09 ` [PATCH 2/2] generic: Test that SEEK_HOLE can find a punched hole Amir Goldstein
2019-03-02 15:25 ` Eryu Guan
2019-03-02 16:09 ` Amir Goldstein
2019-03-02 16:30 ` Eryu Guan
2019-03-02 15:26 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302152643.GE2824@desktop \
--to=guaneryu@gmail.com \
--cc=amir73il@gmail.com \
--cc=eddiehorng.tw@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).