From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Chengguang Xu <cgxu519@mykernel.net>,
zhangyi <yi.zhang@huawei.com>, Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH] overlay/031: fix failure with whiteout inode sharing
Date: Wed, 20 May 2020 11:53:44 +0300 [thread overview]
Message-ID: <20200520085344.2223-1-amir73il@gmail.com> (raw)
Kernel commit c21c839b8448 "ovl: whiteout inode sharing" results in
a temp whiteout file resident inside work dir.
Test overlay/031 is a regression test for two user visible bugs:
1. Exposed whiteouts in overlay
2. Failure to remove directory
It also has a sanity tests for a harmless by-product of the bug -
a residue file in work dir.
The new temp whiteout file looks like a residue and causes the test
to fail.
Drop this sanity test, because it is not vital to the regression test.
We could also check if the residue is a single whiteout, but that is
not really needed, so best not poke into overlay internal work dir.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
Eryu,
This fixes a failure on overlayfs-next.
Test works fine on old kernels after the change of course.
Thanks,
Amir.
tests/overlay/031 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/overlay/031 b/tests/overlay/031
index 2740c7c3..d7a5adb9 100755
--- a/tests/overlay/031
+++ b/tests/overlay/031
@@ -94,7 +94,6 @@ _overlay_scratch_mount_dirs $lowerdir1 $upperdir $workdir
# try to remove test dir from overlay dir, trigger ovl_remove_and_whiteout,
# it will not clean up the dir and lead to residue.
rm -rf $SCRATCH_MNT/testdir 2>&1 | _filter_scratch
-ls $workdir/work
$UMOUNT_PROG $SCRATCH_MNT
--
2.17.1
reply other threads:[~2020-05-20 8:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520085344.2223-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=cgxu519@mykernel.net \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox