From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Giuseppe Scrivano <gscrivan@redhat.com>,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v2] ovl: check for incomapt features in work dir
Date: Mon, 31 Aug 2020 12:12:30 -0400 [thread overview]
Message-ID: <20200831161230.GB1172775@redhat.com> (raw)
In-Reply-To: <20200830202803.25028-1-amir73il@gmail.com>
On Sun, Aug 30, 2020 at 11:28:03PM +0300, Amir Goldstein wrote:
[..]
> @@ -1079,21 +1090,29 @@ static void ovl_workdir_cleanup_recurse(struct path *path, int level)
> continue;
> if (p->len == 2 && p->name[1] == '.')
> continue;
> + } else if (incompat) {
> + pr_warn("overlay with incompat feature '%.*s' cannot be mounted\n",
> + p->len, p->name);
> + err = -EEXIST;
> + break;
Hi Amir,
Should above be pr_err() instead of pr_warn()?
Apart from above minor nit, this patch looks good to me. I did a quick
test and it works.
Vivek
next prev parent reply other threads:[~2020-08-31 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 20:28 [PATCH v2] ovl: check for incomapt features in work dir Amir Goldstein
2020-08-31 16:12 ` Vivek Goyal [this message]
2020-09-01 8:11 ` Amir Goldstein
2020-09-01 9:16 ` Miklos Szeredi
2020-09-01 9:44 ` Amir Goldstein
2020-09-01 10:19 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831161230.GB1172775@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=gscrivan@redhat.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox