From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: "Amir Goldstein" <amir73il@gmail.com>,
"Christoph Hellwig" <hch@lst.de>,
"Miklos Szeredi" <mszeredi@redhat.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
"Aleksa Sarai" <cyphar@cyphar.com>,
"Giuseppe Scrivano" <gscrivan@redhat.com>,
"Rodrigo Campos Catelin" <rodrigo@sdfg.com.ar>,
"Seth Forshee" <sforshee@digitalocean.com>,
"Luca Bocassi" <luca.boccassi@microsoft.com>,
"Lennart Poettering" <mzxreary@0pointer.de>,
"Stéphane Graber" <stgraber@ubuntu.com>
Subject: Re: [PATCH v2 01/19] fs: add two trivial lookup helpers
Date: Wed, 30 Mar 2022 17:25:32 +0200 [thread overview]
Message-ID: <20220330152532.GA4835@lst.de> (raw)
In-Reply-To: <20220330102409.1290850-2-brauner@kernel.org>
> +
> +/*
> + * Like lookup_positive_unlocked() but takes a mount's idmapping into account.
> + */
Can you add a real kerneldoc comment here instead of referring to
another function that will hopefully be removed rather sooner than
later?
> +struct dentry *lookup_one_unlocked(struct user_namespace *, const char *, struct dentry *, int);
> +struct dentry *lookup_one_positive_unlocked(struct user_namespace *, const char *, struct dentry *, int);
Please spellt out the parameter names and avoid the overy long lines.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-03-30 15:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 10:23 [PATCH v2 00/19] overlay: support idmapped layers Christian Brauner
2022-03-30 10:23 ` [PATCH v2 01/19] fs: add two trivial lookup helpers Christian Brauner
2022-03-30 15:25 ` Christoph Hellwig [this message]
2022-03-30 16:02 ` Christian Brauner
2022-03-30 10:23 ` [PATCH v2 02/19] exportfs: support idmapped mounts Christian Brauner
2022-03-30 15:26 ` Christoph Hellwig
2022-03-30 16:04 ` Christian Brauner
2022-03-30 16:08 ` Christoph Hellwig
2022-03-30 16:11 ` Christian Brauner
2022-03-30 10:23 ` [PATCH v2 03/19] ovl: use wrappers to all vfs_*xattr() calls Christian Brauner
2022-03-30 10:23 ` [PATCH v2 04/19] ovl: pass ofs to creation operations Christian Brauner
2022-03-30 10:23 ` [PATCH v2 05/19] ovl: add ovl_upper_idmap() wrapper Christian Brauner
2022-03-30 10:23 ` [PATCH v2 06/19] ovl: handle idmappings in creation operations Christian Brauner
2022-03-30 10:23 ` [PATCH v2 07/19] ovl: pass ofs to setattr operations Christian Brauner
2022-03-30 10:23 ` [PATCH v2 08/19] ovl: pass layer mnt to ovl_open_realfile() Christian Brauner
2022-03-30 10:23 ` [PATCH v2 09/19] ovl: use ovl_do_notify_change() wrapper Christian Brauner
2022-03-30 10:23 ` [PATCH v2 10/19] ovl: use ovl_lookup_upper() wrapper Christian Brauner
2022-03-30 10:23 ` [PATCH v2 11/19] ovl: use ovl_path_getxattr() wrapper Christian Brauner
2022-03-30 10:24 ` [PATCH v2 12/19] ovl: handle idmappings for layer fileattrs Christian Brauner
2022-03-30 10:24 ` [PATCH v2 13/19] ovl: handle idmappings for layer lookup Christian Brauner
2022-03-30 10:24 ` [PATCH v2 14/19] ovl: store lower path in ovl_inode Christian Brauner
2022-03-30 10:24 ` [PATCH v2 15/19] ovl: use ovl_copy_{real,upper}attr() wrappers Christian Brauner
2022-03-30 10:24 ` [PATCH v2 16/19] ovl: handle idmappings in ovl_permission() Christian Brauner
2022-03-30 10:24 ` [PATCH v2 17/19] ovl: handle idmappings in layer open helpers Christian Brauner
2022-03-30 10:24 ` [PATCH v2 18/19] ovl: handle idmappings in ovl_xattr_{g,s}et() Christian Brauner
2022-03-30 10:24 ` [PATCH v2 19/19] ovl: support idmapped layers Christian Brauner
2022-03-30 11:02 ` Amir Goldstein
2022-03-30 11:07 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330152532.GA4835@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=gscrivan@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=luca.boccassi@microsoft.com \
--cc=mszeredi@redhat.com \
--cc=mzxreary@0pointer.de \
--cc=rodrigo@sdfg.com.ar \
--cc=sforshee@digitalocean.com \
--cc=stgraber@ubuntu.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox