Linux Overlay Filesystem development
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: miklos@szeredi.hu, amir73il@gmail.com,
	linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] ovl: Fix null ptr dereference at realinode in rcu-walk
Date: Mon, 15 May 2023 13:04:58 +0200	[thread overview]
Message-ID: <20230515-befestigen-stopfen-ab8100cb6a00@brauner> (raw)
In-Reply-To: <20230505122452.405661-1-chengzhihao1@huawei.com>

On Fri, May 05, 2023 at 08:24:50PM +0800, Zhihao Cheng wrote:
> Zhihao Cheng (2):
>   ovl: get_acl: Fix null pointer dereference at realinode in rcu-walk
>     mode
>   ovl: ovl_permission: Fix null pointer dereference at realinode in
>     rcu-walk mode
> 
>  fs/overlayfs/inode.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Seems fine to me. Thanks for fixing this,
Reviewed-by: Christian Brauner <brauner@kernel.org>

(One thing that might be possible is to move this into a tiny static
inline helper but might not be worth it.)

      parent reply	other threads:[~2023-05-15 11:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 12:24 [PATCH 0/2] ovl: Fix null ptr dereference at realinode in rcu-walk Zhihao Cheng
2023-05-05 12:24 ` [PATCH 1/2] ovl: get_acl: Fix null pointer dereference at realinode in rcu-walk mode Zhihao Cheng
2023-05-15 11:08   ` Christian Brauner
2023-05-05 12:24 ` [PATCH 2/2] ovl: ovl_permission: " Zhihao Cheng
2023-05-15 11:04 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230515-befestigen-stopfen-ab8100cb6a00@brauner \
    --to=brauner@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=chengzhihao1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox