From: Amir Goldstein <amir73il@gmail.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: Cyril Hrubis <chrubis@suse.cz>, Jan Kara <jack@suse.cz>,
Christian Brauner <brauner@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, ltp@lists.linux.it
Subject: [PATCH 3/3] fanotify13: Test unique overlayfs fsid
Date: Sun, 3 Sep 2023 14:15:58 +0300 [thread overview]
Message-ID: <20230903111558.2603332-4-amir73il@gmail.com> (raw)
In-Reply-To: <20230903111558.2603332-1-amir73il@gmail.com>
With feature uuid=auto, overlayfs gets an fsid which is different than
the base fs fsid.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
testcases/kernel/syscalls/fanotify/fanotify13.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/testcases/kernel/syscalls/fanotify/fanotify13.c b/testcases/kernel/syscalls/fanotify/fanotify13.c
index 5c1d287d7..3bb9eb1df 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify13.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify13.c
@@ -96,6 +96,7 @@ static int fanotify_fd;
static int filesystem_mark_unsupported;
static char events_buf[BUF_SIZE];
static struct event_t event_set[EVENT_MAX];
+static struct fanotify_fid_t base_fs_fid;
static void create_objects(void)
{
@@ -113,8 +114,19 @@ static void get_object_stats(void)
{
unsigned int i;
+ fanotify_save_fid(OVL_BASE_MNTPOINT, &base_fs_fid);
for (i = 0; i < ARRAY_SIZE(objects); i++)
fanotify_save_fid(objects[i].path, &objects[i].fid);
+
+ /* Variant #2: watching overlayfs - expect fsid != base fs fsid */
+ if (ovl_mounted && tst_variant == 2 &&
+ memcmp(&objects[0].fid.fsid, &base_fs_fid.fsid,
+ sizeof(base_fs_fid.fsid)) == 0) {
+ tst_res(TFAIL,
+ "overlayfs fsid is the same as stat.f_fsid that was "
+ "obtained via statfs(2) on the base fs");
+ }
+
}
static int setup_marks(unsigned int fd, struct test_case_t *tc)
--
2.34.1
prev parent reply other threads:[~2023-09-03 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 11:15 [PATCH 0/3] Tests for fanotify and overlayfs Amir Goldstein
2023-09-03 11:15 ` [PATCH 1/3] fanotify13: Test watching overlayfs upper fs Amir Goldstein
2023-09-14 10:32 ` [LTP] " Richard Palethorpe
2023-09-14 13:24 ` Amir Goldstein
2023-09-15 6:51 ` Petr Vorel
2023-09-15 8:28 ` Cyril Hrubis
2023-09-15 9:02 ` Petr Vorel
2023-09-03 11:15 ` [PATCH 2/3] fanotify13: Test watching overlayfs with FAN_REPORT_FID Amir Goldstein
2023-09-03 11:15 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230903111558.2603332-4-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chrubis@suse.cz \
--cc=jack@suse.cz \
--cc=linux-unionfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=miklos@szeredi.hu \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox