From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AB70E95A86 for ; Sun, 8 Oct 2023 00:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234408AbjJHAuu (ORCPT ); Sat, 7 Oct 2023 20:50:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234344AbjJHAuS (ORCPT ); Sat, 7 Oct 2023 20:50:18 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16842131; Sat, 7 Oct 2023 17:49:44 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2834C433CD; Sun, 8 Oct 2023 00:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696726182; bh=nil/V9uQ5ZbcCuDueBOKT6XVFcJnRnzoAS/IGHsUZac=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jk+CC1CcnQ/+sxCGwJrv81qv4C3HSunjuVN67JNZuKr4tXk8pGD+REjPPc8Ja9Fvn AOkAxz0vMnsayJ6K6fL+U1h579FT7vTk4fC8/LtZ7WqNVWbdgpv5jHeR+bigPkUDiY JtJ0xvht6asJ3zDNo7IB2CT++IwkUTojVHhPx9etMYQBSBo6Tm5S+BZFaxAzdzO6AM X9uYPmzV9ACjWIh8yeRWx5N9oE2WzsEB4mYXGNDow2mZlLdM8X7O7XW6lAMbKWX8pp ZjXwdx1rMRAxBHqsSF/2YJXhUggsVSZEy6n69vG1POpoB9ZpQkgnEOkAyFhvbTLzV8 7VVt5GdwDZSXg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jeff Layton , Nathan Chancellor , Christian Brauner , Amir Goldstein , Sasha Levin , miklos@szeredi.hu, linux-unionfs@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 08/12] overlayfs: set ctime when setting mtime and atime Date: Sat, 7 Oct 2023 20:49:25 -0400 Message-Id: <20231008004929.3767992-8-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231008004929.3767992-1-sashal@kernel.org> References: <20231008004929.3767992-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.56 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org From: Jeff Layton [ Upstream commit 03dbab3bba5f009d053635c729d1244f2c8bad38 ] Nathan reported that he was seeing the new warning in setattr_copy_mgtime pop when starting podman containers. Overlayfs is trying to set the atime and mtime via notify_change without also setting the ctime. POSIX states that when the atime and mtime are updated via utimes() that we must also update the ctime to the current time. The situation with overlayfs copy-up is analogies, so add ATTR_CTIME to the bitmask. notify_change will fill in the value. Reported-by: Nathan Chancellor Signed-off-by: Jeff Layton Tested-by: Nathan Chancellor Acked-by: Christian Brauner Acked-by: Amir Goldstein Message-Id: <20230913-ctime-v1-1-c6bc509cbc27@kernel.org> Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/overlayfs/copy_up.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index e6d711f42607b..86d4b6975dbcb 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -300,7 +300,7 @@ static int ovl_set_timestamps(struct ovl_fs *ofs, struct dentry *upperdentry, { struct iattr attr = { .ia_valid = - ATTR_ATIME | ATTR_MTIME | ATTR_ATIME_SET | ATTR_MTIME_SET, + ATTR_ATIME | ATTR_MTIME | ATTR_ATIME_SET | ATTR_MTIME_SET | ATTR_CTIME, .ia_atime = stat->atime, .ia_mtime = stat->mtime, }; -- 2.40.1