From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0064E95A85 for ; Sun, 8 Oct 2023 00:51:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234237AbjJHAvt (ORCPT ); Sat, 7 Oct 2023 20:51:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234297AbjJHAvd (ORCPT ); Sat, 7 Oct 2023 20:51:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBB226B6; Sat, 7 Oct 2023 17:50:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D30FC433C9; Sun, 8 Oct 2023 00:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696726233; bh=qfRJbF+Udv0tWMynZn1JUmVoo9ls4SNI9STC6TtqapE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tmlxCwRVh1FaDa9pnGxfodX2rYRc4SDS0Ghny3l7GfqDP5LWs3jedIwjkrE9GSK5r JZG8NThOEzQWqdym27yJ5cKoCw6wGi2hp0lwN5FLqfIMo1RZBA6OgrBmo5RXsNAhnb eFzCv4DTeO7T4AjSpoIdBlO+/vihytImy2fA4002uV6TPbI5eMiEB5zPCDIRRjflH3 AhOdv/N6HZFFWwf3/yoWs2/VshzADfqxzXi7rkTkwb1mDl3YtY0doLR1xwEdPkwzeD 0GqYtqRgW1GLZwFWIS3J/he+Za2PEB+zWU/ZFt2PrMtx0t2dhobzsVfwUszLXyxkk1 n62zeTAnfq9GA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jeff Layton , Nathan Chancellor , Christian Brauner , Amir Goldstein , Sasha Levin , miklos@szeredi.hu, linux-unionfs@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 5/8] overlayfs: set ctime when setting mtime and atime Date: Sat, 7 Oct 2023 20:50:21 -0400 Message-Id: <20231008005024.3768418-5-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231008005024.3768418-1-sashal@kernel.org> References: <20231008005024.3768418-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.257 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org From: Jeff Layton [ Upstream commit 03dbab3bba5f009d053635c729d1244f2c8bad38 ] Nathan reported that he was seeing the new warning in setattr_copy_mgtime pop when starting podman containers. Overlayfs is trying to set the atime and mtime via notify_change without also setting the ctime. POSIX states that when the atime and mtime are updated via utimes() that we must also update the ctime to the current time. The situation with overlayfs copy-up is analogies, so add ATTR_CTIME to the bitmask. notify_change will fill in the value. Reported-by: Nathan Chancellor Signed-off-by: Jeff Layton Tested-by: Nathan Chancellor Acked-by: Christian Brauner Acked-by: Amir Goldstein Message-Id: <20230913-ctime-v1-1-c6bc509cbc27@kernel.org> Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/overlayfs/copy_up.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index 1bfd1660a66c0..9e5223108362d 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -192,7 +192,7 @@ static int ovl_set_timestamps(struct dentry *upperdentry, struct kstat *stat) { struct iattr attr = { .ia_valid = - ATTR_ATIME | ATTR_MTIME | ATTR_ATIME_SET | ATTR_MTIME_SET, + ATTR_ATIME | ATTR_MTIME | ATTR_ATIME_SET | ATTR_MTIME_SET | ATTR_CTIME, .ia_atime = stat->atime, .ia_mtime = stat->mtime, }; -- 2.40.1