From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Christian Brauner <brauner@kernel.org>,
linux-unionfs@vger.kernel.org, linux-doc@vger.kernel.org
Subject: [PATCH 2/2] overlayfs.rst: fix ReST formatting
Date: Tue, 12 Dec 2023 09:33:24 +0200 [thread overview]
Message-ID: <20231212073324.245541-3-amir73il@gmail.com> (raw)
In-Reply-To: <20231212073324.245541-1-amir73il@gmail.com>
Fix some indentation issues and missing newlines in quoted text.
Unindent a) b) enumerated list to workaround github displaying it
as numbered list.
Reported-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
Documentation/filesystems/overlayfs.rst | 69 +++++++++++++------------
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git a/Documentation/filesystems/overlayfs.rst b/Documentation/filesystems/overlayfs.rst
index 926396fdc5eb..37467ad5cff4 100644
--- a/Documentation/filesystems/overlayfs.rst
+++ b/Documentation/filesystems/overlayfs.rst
@@ -174,10 +174,10 @@ programs.
seek offsets are assigned sequentially when the directories are read.
Thus if
- - read part of a directory
- - remember an offset, and close the directory
- - re-open the directory some time later
- - seek to the remembered offset
+- read part of a directory
+- remember an offset, and close the directory
+- re-open the directory some time later
+- seek to the remembered offset
there may be little correlation between the old and new locations in
the list of filenames, particularly if anything has changed in the
@@ -285,21 +285,21 @@ Permission model
Permission checking in the overlay filesystem follows these principles:
- 1) permission check SHOULD return the same result before and after copy up
+1) permission check SHOULD return the same result before and after copy up
- 2) task creating the overlay mount MUST NOT gain additional privileges
+2) task creating the overlay mount MUST NOT gain additional privileges
- 3) non-mounting task MAY gain additional privileges through the overlay,
- compared to direct access on underlying lower or upper filesystems
+3) non-mounting task MAY gain additional privileges through the overlay,
+ compared to direct access on underlying lower or upper filesystems
-This is achieved by performing two permission checks on each access
+This is achieved by performing two permission checks on each access:
- a) check if current task is allowed access based on local DAC (owner,
- group, mode and posix acl), as well as MAC checks
+a) check if current task is allowed access based on local DAC (owner,
+group, mode and posix acl), as well as MAC checks
- b) check if mounting task would be allowed real operation on lower or
- upper layer based on underlying filesystem permissions, again including
- MAC checks
+b) check if mounting task would be allowed real operation on lower or
+upper layer based on underlying filesystem permissions, again including
+MAC checks
Check (a) ensures consistency (1) since owner, group, mode and posix acls
are copied up. On the other hand it can result in server enforced
@@ -311,14 +311,14 @@ to create setups where the consistency rule (1) does not hold; normally,
however, the mounting task will have sufficient privileges to perform all
operations.
-Another way to demonstrate this model is drawing parallels between
+Another way to demonstrate this model is drawing parallels between:
- mount -t overlay overlay -olowerdir=/lower,upperdir=/upper,... /merged
+ mount -t overlay overlay -olowerdir=/lower,upperdir=/upper,... /merged
-and
+and:
- cp -a /lower /upper
- mount --bind /upper /merged
+ | cp -a /lower /upper
+ | mount --bind /upper /merged
The resulting access permissions should be the same. The difference is in
the time of copy (on-demand vs. up-front).
@@ -390,11 +390,11 @@ Data-only lower layers
With "metacopy" feature enabled, an overlayfs regular file may be a composition
of information from up to three different layers:
- 1) metadata from a file in the upper layer
+1) metadata from a file in the upper layer
- 2) st_ino and st_dev object identifier from a file in a lower layer
+2) st_ino and st_dev object identifier from a file in a lower layer
- 3) data from a file in another lower layer (further below)
+3) data from a file in another lower layer (further below)
The "lower data" file can be on any lower layer, except from the top most
lower layer.
@@ -421,15 +421,15 @@ Since kernel version v6.8, "data-only" lower layers can also be added using
the "datadir+" mount options and the fsconfig syscall from new mount api.
For example:
- fsconfig(fs_fd, FSCONFIG_SET_STRING, "lowerdir+", "/l1", 0);
- fsconfig(fs_fd, FSCONFIG_SET_STRING, "lowerdir+", "/l2", 0);
- fsconfig(fs_fd, FSCONFIG_SET_STRING, "lowerdir+", "/l3", 0);
- fsconfig(fs_fd, FSCONFIG_SET_STRING, "datadir+", "/do1", 0);
- fsconfig(fs_fd, FSCONFIG_SET_STRING, "datadir+", "/do2", 0);
+ | fsconfig(fs_fd, FSCONFIG_SET_STRING, "lowerdir+", "/l1", 0);
+ | fsconfig(fs_fd, FSCONFIG_SET_STRING, "lowerdir+", "/l2", 0);
+ | fsconfig(fs_fd, FSCONFIG_SET_STRING, "lowerdir+", "/l3", 0);
+ | fsconfig(fs_fd, FSCONFIG_SET_STRING, "datadir+", "/do1", 0);
+ | fsconfig(fs_fd, FSCONFIG_SET_STRING, "datadir+", "/do2", 0);
fs-verity support
-----------------------
+-----------------
During metadata copy up of a lower file, if the source file has
fs-verity enabled and overlay verity support is enabled, then the
@@ -653,9 +653,10 @@ following rules apply:
encode an upper file handle from upper inode
The encoded overlay file handle includes:
- - Header including path type information (e.g. lower/upper)
- - UUID of the underlying filesystem
- - Underlying filesystem encoding of underlying inode
+
+- Header including path type information (e.g. lower/upper)
+- UUID of the underlying filesystem
+- Underlying filesystem encoding of underlying inode
This encoding format is identical to the encoding format file handles that
are stored in extended attribute "trusted.overlay.origin".
@@ -773,9 +774,9 @@ Testsuite
There's a testsuite originally developed by David Howells and currently
maintained by Amir Goldstein at:
- https://github.com/amir73il/unionmount-testsuite.git
+https://github.com/amir73il/unionmount-testsuite.git
Run as root:
- # cd unionmount-testsuite
- # ./run --ov --verify
+ | # cd unionmount-testsuite
+ | # ./run --ov --verify
--
2.34.1
next prev parent reply other threads:[~2023-12-12 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 7:33 [PATCH 0/2] Fixes to overlayfs documentation Amir Goldstein
2023-12-12 7:33 ` [PATCH 1/2] overlayfs.rst: use consistent terminology Amir Goldstein
2023-12-13 5:00 ` Bagas Sanjaya
2023-12-13 11:26 ` Amir Goldstein
2023-12-12 7:33 ` Amir Goldstein [this message]
2023-12-13 5:16 ` [PATCH 2/2] overlayfs.rst: fix ReST formatting Bagas Sanjaya
2023-12-13 11:58 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212073324.245541-3-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox