Re: [PATCH 2/2] fs: remove the inode argument to ->d_real() method

Amir Goldstein
2024-02-02T12:41:29Z

On Fri, Feb 2, 2024 at 2:19 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Fri, 2 Feb 2024 at 12:01, Amir Goldstein <amir73il@gmail.com> wrote:
>
> > diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> > index d5bf4b6b7509..453039a2e49b 100644
> > --- a/Documentation/filesystems/locking.rst
> > +++ b/Documentation/filesystems/locking.rst
> > @@ -29,7 +29,7 @@ prototypes::
> > char *(*d_dname)((struct dentry *dentry, char *buffer, int buflen);
> > struct vfsmount *(*d_automount)(struct path *path);
> > int (*d_manage)(const struct path *, bool);
> > - struct dentry *(*d_real)(struct dentry *, const struct inode *);
> > + struct dentry *(*d_real)(struct dentry *, int type);
>
> Why not use the specific enum type for the argument?

No reason, we can do enum d_real_type.

Thanks,
Amir.