From: <ed.tsai@mediatek.com>
To: Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: <wsd_upstream@mediatek.com>, <chun-hung.wu@mediatek.com>,
<casper.li@mediatek.com>, Ed Tsai <ed.tsai@mediatek.com>,
<linux-fsdevel@vger.kernel.org>, <linux-unionfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: [PATCH 1/1] backing-file: covert to using fops->splice_write
Date: Fri, 5 Jul 2024 16:16:39 +0800 [thread overview]
Message-ID: <20240705081642.12032-1-ed.tsai@mediatek.com> (raw)
From: Ed Tsai <ed.tsai@mediatek.com>
Filesystems may define their own splice write. Therefore, use file
fops instead of invoking iter_file_splice_write() directly.
Signed-off-by: Ed Tsai <ed.tsai@mediatek.com>
---
fs/backing-file.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/backing-file.c b/fs/backing-file.c
index 740185198db3..687a7fae7d25 100644
--- a/fs/backing-file.c
+++ b/fs/backing-file.c
@@ -280,13 +280,16 @@ ssize_t backing_file_splice_write(struct pipe_inode_info *pipe,
if (WARN_ON_ONCE(!(out->f_mode & FMODE_BACKING)))
return -EIO;
+ if (out->f_op->splice_write)
+ return -EINVAL;
+
ret = file_remove_privs(ctx->user_file);
if (ret)
return ret;
old_cred = override_creds(ctx->cred);
file_start_write(out);
- ret = iter_file_splice_write(pipe, out, ppos, len, flags);
+ ret = out->f_op->splice_write(pipe, out, ppos, len, flags);
file_end_write(out);
revert_creds(old_cred);
--
2.18.0
next reply other threads:[~2024-07-05 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 8:16 ed.tsai [this message]
2024-07-05 8:20 ` [PATCH 1/1] backing-file: covert to using fops->splice_write Ed Tsai (蔡宗軒)
2024-07-05 12:27 ` Amir Goldstein
2024-07-07 20:42 ` Matthew Wilcox
2024-07-07 23:52 ` Ed Tsai (蔡宗軒)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705081642.12032-1-ed.tsai@mediatek.com \
--to=ed.tsai@mediatek.com \
--cc=amir73il@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=brauner@kernel.org \
--cc=casper.li@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jack@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox