From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] ovl: replace dget/dput with d_drop in ovl_cleanup()
Date: Sat, 26 Oct 2024 07:56:19 +0100 [thread overview]
Message-ID: <20241026065619.GD1350452@ZenIV> (raw)
In-Reply-To: <CAOQ4uxhA-o_=4jE2DyNSAW8OWt3vOP1uaaua+t3W5aA-nV+34Q@mail.gmail.com>
On Sat, Oct 26, 2024 at 08:30:54AM +0200, Amir Goldstein wrote:
> On Fri, Oct 25, 2024 at 5:02 PM Miklos Szeredi <mszeredi@redhat.com> wrote:
> >
> > The reason for the dget/dput pair was to force the upperdentry to be
> > dropped from the cache instead of turning it negative and keeping it
> > cached.
> >
> > Simpler and cleaner way to achieve the same effect is to just drop the
> > dentry after unlink/rmdir if it was turned negative.
> >
> > Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
>
> Looks sane.
> Applied to overlayfs-next for testing.
I thought it was about preventing an overlayfs objects with negative ->__upperdentry;
why would a negative dentry in upper layer be a problem otherwise?
next prev parent reply other threads:[~2024-10-26 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 15:01 [PATCH v2] ovl: replace dget/dput with d_drop in ovl_cleanup() Miklos Szeredi
2024-10-26 6:30 ` Amir Goldstein
2024-10-26 6:56 ` Al Viro [this message]
2024-11-05 11:34 ` Miklos Szeredi
2024-11-05 13:58 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026065619.GD1350452@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).