From: Amir Goldstein <amir73il@gmail.com>
To: Zorro Lang <zlang@redhat.com>
Cc: "Miklos Szeredi" <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org,
"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH 4/4] generic/623: do not run with overlayfs
Date: Mon, 26 May 2025 16:35:00 +0200 [thread overview]
Message-ID: <20250526143500.1520660-6-amir73il@gmail.com> (raw)
In-Reply-To: <20250526143500.1520660-1-amir73il@gmail.com>
This test performs shutdown via xfs_io -c shutdown.
Overlayfs tests can use _scratch_shutdown, but they cannot use
"-c shutdown" xfs_io command without jumping through hoops, so by
default we do not support it.
Add this condition to _require_xfs_io_command and add the require
statement to test generic/623 so it wont run with overlayfs.
Reported-by: André Almeida <andrealmeid@igalia.com>
Link: https://lore.kernel.org/linux-fsdevel/20250521-ovl_ro-v1-1-2350b1493d94@igalia.com/
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
common/rc | 8 ++++++++
tests/generic/623 | 1 +
2 files changed, 9 insertions(+)
diff --git a/common/rc b/common/rc
index d8ee8328..bffd576a 100644
--- a/common/rc
+++ b/common/rc
@@ -3033,6 +3033,14 @@ _require_xfs_io_command()
touch $testfile
testio=`$XFS_IO_PROG -c "syncfs" $testfile 2>&1`
;;
+ "shutdown")
+ if [ $FSTYP = "overlay" ]; then
+ # Overlayfs tests can use _scratch_shutdown, but they
+ # cannot use "-c shutdown" xfs_io command without jumping
+ # through hoops, so by default we do not support it.
+ _notrun "xfs_io $command not supported on $FSTYP"
+ fi
+ ;;
*)
testio=`$XFS_IO_PROG -c "help $command" 2>&1`
esac
diff --git a/tests/generic/623 b/tests/generic/623
index b97e2adb..4e36daaf 100755
--- a/tests/generic/623
+++ b/tests/generic/623
@@ -16,6 +16,7 @@ _begin_fstest auto quick shutdown mmap
_require_scratch_nocheck
_require_scratch_shutdown
+_require_xfs_io_command "shutdown"
_scratch_mkfs &>> $seqres.full
_scratch_mount
--
2.34.1
next prev parent reply other threads:[~2025-05-26 14:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 14:34 [PATCH 0/4] fstests overlay fixes for v2025.05.25 Amir Goldstein
2025-05-26 14:34 ` [PATCH 1/4] overlay: workaround libmount failure to remount,ro Amir Goldstein
2025-05-27 14:48 ` Miklos Szeredi
2025-05-28 6:54 ` Amir Goldstein
2025-05-28 8:47 ` Karel Zak
2025-05-28 9:56 ` Miklos Szeredi
2025-05-28 10:54 ` Karel Zak
2025-05-28 11:47 ` Miklos Szeredi
2025-05-28 13:13 ` Karel Zak
2025-05-28 13:27 ` Miklos Szeredi
2025-05-28 10:58 ` Amir Goldstein
2025-05-26 14:34 ` [PATCH 2/4] overlay: fix regression in _repair_overlay_scratch_fs Amir Goldstein
2025-05-26 14:34 ` [PATCH 3/4] generic/604: do not run with overlayfs Amir Goldstein
2025-05-26 14:34 ` [PATCH 3/4] generic/604: opt-out " Amir Goldstein
2025-05-26 14:35 ` Amir Goldstein [this message]
2025-05-26 17:05 ` [PATCH 0/4] fstests overlay fixes for v2025.05.25 André Almeida
2025-05-27 9:11 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526143500.1520660-6-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).