From: Christian Brauner <brauner@kernel.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
josef@toxicpanda.com, kernel-team@fb.com, amir73il@gmail.com,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v6 3/4] Manual conversion of ->i_state uses
Date: Mon, 29 Sep 2025 11:30:36 +0200 [thread overview]
Message-ID: <20250929-babysitten-weinlaune-9cf5da52b8b2@brauner> (raw)
In-Reply-To: <CAGudoHGuFSfSCZcoky+5wX1QfVpg-tj42c2SJijfT7ke_6tR7Q@mail.gmail.com>
On Thu, Sep 25, 2025 at 12:07:13PM +0200, Mateusz Guzik wrote:
> allmodconfig build was done on this patchset but somehow one failure was missed:
>
> diff --git a/fs/afs/inode.c b/fs/afs/inode.c
> index e9538e91f848..71ec043f7569 100644
> --- a/fs/afs/inode.c
> +++ b/fs/afs/inode.c
> @@ -427,7 +427,7 @@ static void afs_fetch_status_success(struct
> afs_operation *op)
> struct afs_vnode *vnode = vp->vnode;
> int ret;
>
> - if (vnode->netfs.inode.i_state & I_NEW) {
> + if (inode_state_read(&vnode->netfs.inode) & I_NEW) {
> ret = afs_inode_init_from_status(op, vp, vnode);
> afs_op_set_error(op, ret);
> if (ret == 0)
>
>
> I reran the thing with this bit and now it's all clean. I think this
> can be folded into the manual fixup patch (the one i'm responding to)
> instead of resending the patchset
Folded, thanks!
next prev parent reply other threads:[~2025-09-29 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 10:47 [PATCH v6 0/4] hide ->i_state behind accessors Mateusz Guzik
2025-09-23 10:47 ` [PATCH v6 1/4] fs: provide accessors for ->i_state Mateusz Guzik
2025-09-23 10:47 ` [PATCH v6 2/4] Convert the kernel to use ->i_state accessors Mateusz Guzik
2025-09-23 10:47 ` [PATCH v6 3/4] Manual conversion of ->i_state uses Mateusz Guzik
2025-09-25 10:07 ` Mateusz Guzik
2025-09-29 9:30 ` Christian Brauner [this message]
2025-09-23 10:47 ` [PATCH v6 4/4] fs: make plain ->i_state access fail to compile Mateusz Guzik
2025-09-23 11:16 ` [PATCH v6 0/4] hide ->i_state behind accessors Jan Kara
2025-09-23 13:16 ` Dave Chinner
2025-09-29 9:30 ` Christian Brauner
2025-09-29 12:56 ` Mateusz Guzik
2025-10-06 11:38 ` Christian Brauner
2025-10-06 13:16 ` Mateusz Guzik
2025-10-07 11:07 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250929-babysitten-weinlaune-9cf5da52b8b2@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox