[PATCH] ovl: remove redundant IOCB_DIO_CALLER_COMP clearing

[PATCH] ovl: remove redundant IOCB_DIO_CALLER_COMP clearing

[Seong-Gwang Heo]

The backing_file_write_iter() function, which is called
immediately after this code, already contains identical
logic to clear the IOCB_DIO_CALLER_COMP flag along with
the same explanatory comment. There is no need to duplicate
this operation in the overlayfs code.

Signed-off-by: Seong-Gwang Heo <heo@mykernel.net>
---
 fs/overlayfs/file.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index f5b8877d5fe2..31a98f10fc4b 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -369,11 +369,6 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
 	if (!ovl_should_sync(OVL_FS(inode->i_sb)))
 		ifl &= ~(IOCB_DSYNC | IOCB_SYNC);
 
-	/*
-	 * Overlayfs doesn't support deferred completions, don't copy
-	 * this property in case it is set by the issuer.
-	 */
-	ifl &= ~IOCB_DIO_CALLER_COMP;
 	ret = backing_file_write_iter(realfile, iter, iocb, ifl, &ctx);
 
 out_unlock:
-- 
2.49.0

Re: [PATCH] ovl: remove redundant IOCB_DIO_CALLER_COMP clearing

[Miklos Szeredi]

On Thu, 9 Oct 2025 at 07:42, Seong-Gwang Heo <heo@mykernel.net> wrote:
>
> The backing_file_write_iter() function, which is called
> immediately after this code, already contains identical
> logic to clear the IOCB_DIO_CALLER_COMP flag along with
> the same explanatory comment. There is no need to duplicate
> this operation in the overlayfs code.
>
> Signed-off-by: Seong-Gwang Heo <heo@mykernel.net>

Fixes: a6293b3e285c ("fs: factor out backing_file_{read,write}_iter() helpers")
Acked-by: Miklos Szeredi <mszeredi@redhat.com>

Thanks,
Miklos

Re: [PATCH] ovl: remove redundant IOCB_DIO_CALLER_COMP clearing

[Amir Goldstein]

On Thu, Oct 9, 2025 at 11:56 AM Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Thu, 9 Oct 2025 at 07:42, Seong-Gwang Heo <heo@mykernel.net> wrote:
> >
> > The backing_file_write_iter() function, which is called
> > immediately after this code, already contains identical
> > logic to clear the IOCB_DIO_CALLER_COMP flag along with
> > the same explanatory comment. There is no need to duplicate
> > this operation in the overlayfs code.
> >
> > Signed-off-by: Seong-Gwang Heo <heo@mykernel.net>
>
> Fixes: a6293b3e285c ("fs: factor out backing_file_{read,write}_iter() helpers")
> Acked-by: Miklos Szeredi <mszeredi@redhat.com>
>

Thanks Seong-Gwang!

Reviewed-by: Amir Goldstein <amir73il@gmail.com>

Christian,

Could you pick up this fix for the next vfs fixes PR?

Thanks,
Amir.

Re: [PATCH] ovl: remove redundant IOCB_DIO_CALLER_COMP clearing

[Christian Brauner]

On Thu, 09 Oct 2025 13:41:48 +0800, Seong-Gwang Heo wrote:
> The backing_file_write_iter() function, which is called
> immediately after this code, already contains identical
> logic to clear the IOCB_DIO_CALLER_COMP flag along with
> the same explanatory comment. There is no need to duplicate
> this operation in the overlayfs code.
> 
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] ovl: remove redundant IOCB_DIO_CALLER_COMP clearing
      https://git.kernel.org/vfs/vfs/c/7933a585d70e