From: Joanne Koong <joannelkoong@gmail.com>
To: amir73il@gmail.com, miklos@szeredi.hu
Cc: fuse-devel@lists.linux.dev, linux-unionfs@vger.kernel.org
Subject: [PATCH v2 13/21] fuse: add passthrough lookup
Date: Fri, 15 May 2026 17:39:56 -0700 [thread overview]
Message-ID: <20260516004004.1455526-14-joannelkoong@gmail.com> (raw)
In-Reply-To: <20260516004004.1455526-1-joannelkoong@gmail.com>
Use the new/extended struct fuse_entry2_out for lookups. If a backing id
is set, associate the fuse inode with the backing inode that should be
used for passthrough operations.
If no backing id was set, cache the statx attributes from the reply.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
fs/fuse/dir.c | 66 ++++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 52 insertions(+), 14 deletions(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index b7a9d2b0476a..3a6adae530da 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -420,10 +420,10 @@ static void fuse_entry2_to_entry(struct fuse_entry2_out *outarg2,
outarg->attr.flags = outarg2->flags;
}
-static __maybe_unused int fuse_process_entry2(struct fuse_conn *fc,
- struct fuse_entry2_out *outarg2,
- struct fuse_entry_out *outarg,
- struct fuse_statx **sxp)
+static int fuse_process_entry2(struct fuse_conn *fc,
+ struct fuse_entry2_out *outarg2,
+ struct fuse_entry_out *outarg,
+ struct fuse_statx **sxp)
{
if (!fuse_use_entry2(fc))
return 0;
@@ -469,7 +469,9 @@ static int fuse_dentry_revalidate(struct inode *dir, const struct qstr *name,
struct fuse_entry_out outarg;
struct fuse_entry2_out outarg2;
struct fuse_forget_link *forget;
+ struct fuse_statx *sx = NULL;
FUSE_ARGS(args);
+ int backing_id = 0;
u64 attr_version;
bool need_reval;
int ret;
@@ -512,15 +514,27 @@ static int fuse_dentry_revalidate(struct inode *dir, const struct qstr *name,
fuse_lookup_init(fc, &args, get_node_id(dir), name, &outarg, &outarg2);
ret = fuse_simple_request(get_fuse_mount(inode), &args);
+ if (!ret)
+ backing_id = fuse_process_entry2(fc, &outarg2, &outarg, &sx);
if (ret || !outarg.nodeid) {
kfree(forget);
return (ret == -ENOMEM || ret == -EINTR) ? ret : 0;
}
+ if (backing_id < 0) {
+ ret = backing_id;
+ goto forget;
+ }
+
+ ret = 0;
if (outarg.nodeid != get_node_id(inode) ||
- !!IS_AUTOMOUNT(inode) != !!(outarg.attr.flags & FUSE_ATTR_SUBMOUNT)) {
- fuse_chan_queue_forget(fc->chan, forget, outarg.nodeid, 1);
- return 0;
+ !!IS_AUTOMOUNT(inode) != !!(outarg.attr.flags & FUSE_ATTR_SUBMOUNT))
+ goto forget;
+
+ if (backing_id) {
+ ret = fuse_inode_set_passthrough(inode, backing_id);
+ if (ret)
+ goto forget;
}
kfree(forget);
@@ -534,10 +548,14 @@ static int fuse_dentry_revalidate(struct inode *dir, const struct qstr *name,
return 0;
forget_all_cached_acls(inode);
- fuse_change_attributes(inode, &outarg.attr, NULL, ATTR_TIMEOUT(&outarg),
+ fuse_change_attributes(inode, &outarg.attr, sx, ATTR_TIMEOUT(&outarg),
attr_version);
fuse_change_entry_timeout(entry, &outarg);
return 1;
+
+forget:
+ fuse_chan_queue_forget(fc->chan, forget, outarg.nodeid, 1);
+ return ret;
}
static int fuse_dentry_init(struct dentry *dentry)
@@ -631,6 +649,8 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
struct fuse_forget_link *forget;
u64 attr_version, evict_ctr;
struct fuse_entry2_out outarg2;
+ struct fuse_statx *sx = NULL;
+ int backing_id;
int err;
*inode = NULL;
@@ -649,9 +669,18 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
fuse_lookup_init(fm->fc, &args, nodeid, name, outarg, &outarg2);
err = fuse_simple_request(fm, &args);
+ if (err)
+ goto out_put_forget;
+
+ backing_id = fuse_process_entry2(fm->fc, &outarg2, outarg, &sx);
+
/* Zero nodeid is same as -ENOENT, but with valid timeout */
- if (err || !outarg->nodeid)
+ if (!outarg->nodeid)
goto out_put_forget;
+ if (backing_id < 0) {
+ err = backing_id;
+ goto out_send_forget;
+ }
err = -EIO;
if (fuse_invalid_attr(&outarg->attr))
@@ -662,19 +691,28 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
}
*inode = fuse_iget(sb, outarg->nodeid, outarg->generation,
- &outarg->attr, NULL, ATTR_TIMEOUT(outarg),
+ &outarg->attr, sx, ATTR_TIMEOUT(outarg),
attr_version, evict_ctr);
err = -ENOMEM;
- if (!*inode) {
- fuse_chan_queue_forget(fm->fc->chan, forget, outarg->nodeid, 1);
- goto out;
- }
+ if (!*inode)
+ goto out_send_forget;
+
err = 0;
+ if (backing_id) {
+ err = fuse_inode_set_passthrough(*inode, backing_id);
+ if (err) {
+ iput(*inode);
+ *inode = NULL;
+ }
+ }
out_put_forget:
kfree(forget);
out:
return err;
+ out_send_forget:
+ fuse_chan_queue_forget(fm->fc->chan, forget, outarg->nodeid, 1);
+ return err;
}
static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry,
--
2.52.0
next prev parent reply other threads:[~2026-05-16 0:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 0:39 [PATCH v2 00/21] fuse: extend passthrough to inode operations Joanne Koong
2026-05-16 0:39 ` [PATCH v2 01/21] fuse: introduce FUSE_PASSTHROUGH_INO mode Joanne Koong
2026-05-16 0:39 ` [PATCH v2 02/21] fuse: prepare for passthrough of inode operations Joanne Koong
2026-05-16 1:34 ` Joanne Koong
2026-05-16 0:39 ` [PATCH v2 03/21] fuse: prepare for readdir passthrough on directories Joanne Koong
2026-05-16 0:39 ` [PATCH v2 04/21] fuse: implement passthrough for readdir Joanne Koong
2026-05-16 0:39 ` [PATCH v2 05/21] fuse: prepare for long lived reference on backing file Joanne Koong
2026-05-16 0:39 ` [PATCH v2 06/21] fuse: implement passthrough for getattr/statx Joanne Koong
2026-05-16 0:39 ` [PATCH v2 07/21] fuse: prepare to setup backing inode passthrough on lookup Joanne Koong
2026-05-16 0:39 ` [PATCH v2 08/21] fuse: handle zero ops_mask in FUSE_DEV_IOC_BACKING_OPEN Joanne Koong
2026-05-16 0:39 ` [PATCH v2 09/21] fuse: handle partial io passthrough for read/write, splice, and mmap Joanne Koong
2026-05-16 0:39 ` [PATCH v2 10/21] fuse: prepare to cache statx attributes from entry replies Joanne Koong
2026-05-16 0:39 ` [PATCH v2 11/21] fuse: clean up fuse_dentry_revalidate() Joanne Koong
2026-05-16 0:39 ` [PATCH v2 12/21] fuse: add struct fuse_entry2_out and helpers for extended entry replies Joanne Koong
2026-05-16 0:39 ` Joanne Koong [this message]
2026-05-16 0:39 ` [PATCH v2 14/21] fuse: add passthrough support for entry creation Joanne Koong
2026-05-16 0:39 ` [PATCH v2 15/21] fuse: add passthrough support for create+open Joanne Koong
2026-05-16 0:39 ` [PATCH v2 16/21] fuse: allow backing_id=0 in open to inherit inode's backing file Joanne Koong
2026-05-16 0:40 ` [PATCH v2 17/21] backing-inode: add backing_inode_copyattr() Joanne Koong
2026-05-16 0:40 ` [PATCH v2 18/21] backing-inode: add backing_inode_setattr() Joanne Koong
2026-05-16 0:40 ` [PATCH v2 19/21] fuse: add passthrough setattr Joanne Koong
2026-05-16 1:04 ` Joanne Koong
2026-05-16 0:40 ` [PATCH v2 20/21] fuse: use passthrough getattr in setattr suid/sgid handling Joanne Koong
2026-05-16 1:20 ` Joanne Koong
2026-05-16 0:40 ` [PATCH v2 21/21] docs: fuse: document extended passthrough (FUSE_PASSTHROUGH_INO) Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516004004.1455526-14-joannelkoong@gmail.com \
--to=joannelkoong@gmail.com \
--cc=amir73il@gmail.com \
--cc=fuse-devel@lists.linux.dev \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox